@gabobert Universal test failure

FAIL: test_two_keys_two_vars (test_recfunctions.TestJoinBy2)

----------------------------------------------------------------------

Traceback (most recent call last):

File "/home/travis/virtualenv/python2.6/lib/python2.6/site-packages/numpy/lib/tests/test_recfunctions.py", line 679, in test_two_keys_two_vars

assert_equal(test.dtype, control.dtype)

File "/home/travis/virtualenv/python2.6/lib/python2.6/site-packages/numpy/ma/testutils.py", line 100, in assert_equal

raise AssertionError(msg)

AssertionError:

Items are not equal:

ACTUAL: dtype([('a', '<i8'), ('k', '<i8'), ('b1', '<i8'), ('b2', '<i8'), ('c1', '<i8'), ('c2', '<i8')])

DESIRED: dtype([('k', '<i8'), ('a', '<i8'), ('b1', '<i8'), ('b2', '<i8'), ('c1', '<i8'), ('c2', '<i8')])

Now that joining two arrays with differently ordered key-fields is supported, the order of the key-fields in the returned array should match the key argument of join_by in my opinion. So the test should be changed to reflect this.

@gabobert Then you should change the test to match what it should return ;) It would be a good idea to post this change to the list for discussion.

#4216 is still open, but seems to have been fixed somewhere along the line. @ahaldane Comment?

I just tested, and #4216 was fixed by #5480. Specifically, that PR allows casting between structured types with differently ordered fields, which fixes #4216. I'll go ahead and close that issue and this PR.

Also, pinging myself in #6053 to think about this case. (I rework behavior of re-ordered fields there).