ndarray.max() and .min() can now work on arrays of type 'S' and 'U' as s... #5596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s suggested in issue numpy#1914 . I've added function _String_Min_Or_Max to methods.c and updated functions array_min and array_max to handle string ndarrays. One can launch this functions with arguments - keepdims, out and axis (which can be a tuple to enable multidimensional reductions). The solution is based on PyArray_ArgMin and PyArray_Argmax functs, as suggested in issue. I've also created class TestMax in core/tests/test_multidimensional.py in which several tests are placed.
|
HI @Prastaruszek, thanks for submitting this PR. The error in the tests is due to the On a separate note, please take a look at the Numpy C Style Guide and adapt your code to it. The most obvious violation is not using 4 space indents through out. |
|
Rejigger tests by closing and opening. |
|
No response to @jaimefrio's comment in 2015, so this pull request appears to be abandoned. Closing, but discussion can continue if there is interest in resuming work on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am begginer to numpy and it's possible, this pull request needs some tune up to be completed. I will be very thankfull for all comments and advices.
I wrote some code on issue #1914 to enable calculating .min() and .max of arrays of types 'S' and 'U'.
I've added function _String_Min_Or_Max to methods.c and updated functions
array_min and array_max to handle string ndarrays. One can launch this
functions with arguments - keepdims, out and axis (which can be a tuple
to enable multidimensional reductions). The solution is based
on PyArray_ArgMin and PyArray_Argmax functs, as suggested in issue.
I've also created class TestMax in core/tests/test_multidimensional.py
in which several tests are placed.