Refactor 2024 day 2

nycofox · nycofox · commit b7a8a1eab82a · 2024-12-02T13:11:10.000+01:00
diff --git a/src/AdventSolutions/Year2024/Day2/Solution2024Day2.php b/src/AdventSolutions/Year2024/Day2/Solution2024Day2.php
@@ -32,18 +32,13 @@ public function solvePart2($input, $debug = false): string
         return "Number of safe reports (with dampeners): <info>$safeReports</info>";
     }
 
-    private function getLevels($line)
+    private function getLevels($line): array
     {
         return explode(" ", $line);
     }
 
     private function isSafe($levels, $ignoreLevels = 0): bool
     {
-        if (count($levels) < 2) {
-            return true; // A single level or empty array is trivially safe
-        }
-
-        // Helper function to validate the sequence
         $isValid = function ($levels) {
             return $this->isValid($levels);
         };

Original file line number	Diff line number	Diff line change
`@@ -32,18 +32,13 @@ public function solvePart2($input, $debug = false): string`
`32`	`32`	`return "Number of safe reports (with dampeners): <info>$safeReports</info>";`
`33`	`33`	`}`
`34`	`34`
`35`		`- private function getLevels($line)`
	`35`	`+ private function getLevels($line): array`
`36`	`36`	`{`
`37`	`37`	`return explode(" ", $line);`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`private function isSafe($levels, $ignoreLevels = 0): bool`
`41`	`41`	`{`
`42`		`- if (count($levels) < 2) {`
`43`		`- return true; // A single level or empty array is trivially safe`
`44`		`- }`
`45`		`-`
`46`		`- // Helper function to validate the sequence`
`47`	`42`	`$isValid = function ($levels) {`
`48`	`43`	`return $this->isValid($levels);`
`49`	`44`	`};`