[eslint-config] [*] [fix] whitespace: only set erroring rules to "warn"

ljharb · ljharb · commit 370793b3ddfe · 2019-12-10T16:32:17.000-08:00
Fixes airbnb#2105
diff --git a/packages/eslint-config-airbnb-base/whitespace.js b/packages/eslint-config-airbnb-base/whitespace.js
@@ -4,6 +4,18 @@ const { CLIEngine } = require('eslint');
 
 const baseConfig = require('.');
 
+const severities = ['off', 'warn', 'error'];
+
+function getSeverity(ruleConfig) {
+  if (Array.isArray(ruleConfig)) {
+    return getSeverity(ruleConfig[0]);
+  }
+  if (typeof ruleConfig === 'number') {
+    return severities[ruleConfig];
+  }
+  return ruleConfig;
+}
+
 function onlyErrorOnRules(rulesToError, config) {
   const errorsOnly = assign({}, config);
   const cli = new CLIEngine({ baseConfig: config, useEslintrc: false });
@@ -12,8 +24,9 @@ function onlyErrorOnRules(rulesToError, config) {
   entries(baseRules).forEach((rule) => {
     const ruleName = rule[0];
     const ruleConfig = rule[1];
+    const severity = getSeverity(ruleConfig);
 
-    if (rulesToError.indexOf(ruleName) === -1) {
+    if (rulesToError.indexOf(ruleName) === -1 && severity === 'error') {
       if (Array.isArray(ruleConfig)) {
         errorsOnly.rules[ruleName] = ['warn'].concat(ruleConfig.slice(1));
       } else if (typeof ruleConfig === 'number') {
diff --git a/packages/eslint-config-airbnb/whitespace.js b/packages/eslint-config-airbnb/whitespace.js
@@ -4,6 +4,18 @@ const { CLIEngine } = require('eslint');
 
 const baseConfig = require('.');
 
+const severities = ['off', 'warn', 'error'];
+
+function getSeverity(ruleConfig) {
+  if (Array.isArray(ruleConfig)) {
+    return getSeverity(ruleConfig[0]);
+  }
+  if (typeof ruleConfig === 'number') {
+    return severities[ruleConfig];
+  }
+  return ruleConfig;
+}
+
 function onlyErrorOnRules(rulesToError, config) {
   const errorsOnly = assign({}, config);
   const cli = new CLIEngine({ baseConfig: config, useEslintrc: false });
@@ -12,8 +24,9 @@ function onlyErrorOnRules(rulesToError, config) {
   entries(baseRules).forEach((rule) => {
     const ruleName = rule[0];
     const ruleConfig = rule[1];
+    const severity = getSeverity(ruleConfig);
 
-    if (rulesToError.indexOf(ruleName) === -1) {
+    if (rulesToError.indexOf(ruleName) === -1 && severity === 'error') {
       if (Array.isArray(ruleConfig)) {
         errorsOnly.rules[ruleName] = ['warn'].concat(ruleConfig.slice(1));
       } else if (typeof ruleConfig === 'number') {
