fix: provide empty object when data is not set in request

Sergio-svb · Sergio-svb · commit 5ddd16158631 · 2021-11-05T11:56:01.000+03:00
diff --git a/.gitignore b/.gitignore
@@ -4,4 +4,5 @@ run.sh
 coverage
 .idea
 .vscode
-.nyc_output
+.nyc_output
+.env
diff --git a/lib/oneflow.js b/lib/oneflow.js
@@ -21,7 +21,7 @@ function OneFlowClient(baseUrl, token, secret, options = {}) {
 		const headers = makeHeaders(url, method, options);
 		const axiosRetry = options['axios-retry'] || {};
 		return client
-			.request({ method, url, data, headers, 'axios-retry': axiosRetry })
+			.request({ method, url, data: data || {}, headers, 'axios-retry': axiosRetry })
 			.then(res => res.data);
 	}
 
diff --git a/test/oneflow.test.js b/test/oneflow.test.js
@@ -115,6 +115,33 @@ describe('Oneflow', function () {
 			    'content-type',
 		    ]);
 		});
+		
+		it('should perform an http request with data=null', async () => {
+		    stubs.axiosRequest = sinon.stub(sdk.client, 'request').callsFake(a => Promise.resolve({ data: a }));
+
+		    const result = await sdk.request('get', '/order', null);
+
+		    result.method.should.be.equal('get');
+		    result.data.should.be.eql({});
+		});
+		
+		it('should perform an http request with data=undefined', async () => {
+		    stubs.axiosRequest = sinon.stub(sdk.client, 'request').callsFake(a => Promise.resolve({ data: a }));
+
+		    const result = await sdk.request('get', '/order', undefined);
+
+		    result.method.should.be.equal('get');
+		    result.data.should.be.eql({});
+		});
+		
+		it('should perform an http request with data=""', async () => {
+		    stubs.axiosRequest = sinon.stub(sdk.client, 'request').callsFake(a => Promise.resolve({ data: a }));
+
+		    const result = await sdk.request('get', '/order', '');
+
+		    result.method.should.be.equal('get');
+		    result.data.should.be.eql({});
+		});
 
 		it('should support service user requests', async () => {
 		    stubs.axiosRequest = sinon.stub(sdk.client, 'request').callsFake(a => Promise.resolve({ data: a }));

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ function OneFlowClient(baseUrl, token, secret, options = {}) {`
`21`	`21`	`const headers = makeHeaders(url, method, options);`
`22`	`22`	`const axiosRetry = options['axios-retry'] \|\| {};`
`23`	`23`	`return client`
`24`		`- .request({ method, url, data, headers, 'axios-retry': axiosRetry })`
	`24`	`+ .request({ method, url, data: data \|\| {}, headers, 'axios-retry': axiosRetry })`
`25`	`25`	`.then(res => res.data);`
`26`	`26`	`}`
`27`	`27`