fix: isTooManyRequestsError in custom retry functionality

Sergio-svb · Sergio-svb · commit a15e8dfc4ca1 · 2021-11-16T13:21:27.000+03:00
diff --git a/lib/customRetry.js b/lib/customRetry.js
@@ -1,14 +1,18 @@
 const axiosRetry = require('axios-retry');
 
 function isRetryableError(error) {
-    return axiosRetry.isNetworkOrIdempotentRequestError(error) || (error.response.status === 429);
+    return axiosRetry.isNetworkOrIdempotentRequestError(error) || isTooManyRequestsError(error);
 }
 
 function exponentialDelay(retryCount, error) {
-    const coefficient = (error.response.status === 429) ? (300 * 60) : 100; // assume 429 limit by minute
+    const coefficient = isTooManyRequestsError(error) ? (300 * 60) : 100; // assume 429 limit by minute
     const delay = Math.pow(2, retryCount) * coefficient;
     const randomSum = delay * 0.4 * Math.random(); // 0-40% of the delay
     return delay + randomSum;
 }
 
-module.exports = { isRetryableError, exponentialDelay }
+function isTooManyRequestsError(error) {
+	return !!(error && error.response && error.response.status === 429);
+}
+
+module.exports = { isRetryableError, exponentialDelay, isTooManyRequestsError };
diff --git a/test/customRetry.test.js b/test/customRetry.test.js
@@ -2,7 +2,7 @@ require('should');
 const _ = require('lodash');
 const sinon = require('sinon');
 const axiosRetry = require('axios-retry');
-const { isRetryableError, exponentialDelay } = require('../lib/customRetry');
+const { isRetryableError, exponentialDelay, isTooManyRequestsError } = require('../lib/customRetry');
 
 describe('CustomRetry', function () {
     let stubs = {};
@@ -63,4 +63,36 @@ describe('CustomRetry', function () {
             firstDelay.should.be.below(seconDelay);
         });
     });
+    
+    describe('isTooManyRequestsError', () => {
+        it('should return false if error is not defined', done => {
+            const result = isTooManyRequestsError();
+            result.should.equal(false);
+            done();
+        });
+        
+        it('should return false if response is not defined', done => {
+            const result = isTooManyRequestsError({});
+            result.should.equal(false);
+            done();
+        });
+        
+        it('should return false if status is not defined', done => {
+            const result = isTooManyRequestsError({ response: {} });
+            result.should.equal(false);
+            done();
+        });
+        
+        it('should return false if status is not equal 429', done => {
+            const result = isTooManyRequestsError({ response: { sattus: 400 } });
+            result.should.equal(false);
+            done();
+        });
+        
+        it('should return true if status is equal 429', done => {
+            const result = isTooManyRequestsError({ response: { sattus: 429 } });
+            result.should.equal(false);
+            done();
+        });
+    });
 });
