Skip to content

Commit 2f2fcf8

Browse files
authored
Make sure that default_arg is not passed rather than checking for falsity
``` if not default_arg: ... ``` fails when `default_arg` can be assigned and still be false (implementing a `__bool__` or `__len__` etc). You dont want to overwrite the passed values.
1 parent 99280f5 commit 2f2fcf8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2173,7 +2173,7 @@ def some_func(default_arg=[]):
21732173
21742174
```py
21752175
def some_func(default_arg=None):
2176-
if not default_arg:
2176+
if default_arg is not None:
21772177
default_arg = []
21782178
default_arg.append("some_string")
21792179
return default_arg

0 commit comments

Comments
 (0)