feat: OTel hook changes for hook interface updates #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
|
I see there is another issue about bumping the go-sdk to 1.15 over all because there has been some conflict. This PR still needs to bump to 1.15 which I'm happy to do now that it is out but curious if issue #686 needs to be finished so it is bumped for everyone for me to bump it up here and things to pass? |
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com>
sahidvelji
approved these changes
Jun 13, 2025
|
I don't think we need the |
|
I know when the in #642 it is stated it’s a breaking change but okay because of the spec which is why I put the |
beeme1mr
approved these changes
Jun 13, 2025
gdegiorgio
pushed a commit
to gdegiorgio/go-sdk-contrib
that referenced
this pull request
Jul 19, 2025
Signed-off-by: bbland1 <104288486+bbland1@users.noreply.github.com> Signed-off-by: Giovanni De Giorgio <giovannidegiorgio1999@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
go-sdkversion to 1.14.1evalDetailsto the parameters passed in theFinallyhook inmetricshookmetrics_testto have the newevalDetailsRelated Issues
Fixes #642
Notes
go-sdkversion to the unreleased version with the change to theHookit currently throws an error where it is called inmetricsbecause the type issue