diff --git a/.github/workflows/pullrequest.yml b/.github/workflows/pullrequest.yml index 6fde6ef2..9144328c 100644 --- a/.github/workflows/pullrequest.yml +++ b/.github/workflows/pullrequest.yml @@ -13,23 +13,24 @@ jobs: build: - java: 17 profile: codequality - - java: 8 - profile: java8 + - java: 11 + profile: java11 name: with Java ${{ matrix.build.java }} runs-on: ${{ matrix.os}} steps: - name: Check out the code uses: actions/checkout@85e6279cec87321a52edac9c87bce653a07cf6c2 - - name: Set up JDK 8 + - name: Set up JDK 11 uses: actions/setup-java@148017a9b0c6af80330bcc5db11d1c670d2e7074 + with: java-version: ${{ matrix.build.java }} distribution: 'temurin' cache: maven - name: Initialize CodeQL - uses: github/codeql-action/init@362ef4ce205154842cd1d34794abd82bb8f12cd5 + uses: github/codeql-action/init@d26c46acea4065b13fc57703621e0a7c8b9e836b with: languages: java @@ -55,4 +56,4 @@ jobs: verbose: true # optional (default = false) - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@362ef4ce205154842cd1d34794abd82bb8f12cd5 + uses: github/codeql-action/analyze@d26c46acea4065b13fc57703621e0a7c8b9e836b diff --git a/.github/workflows/static-code-scanning.yaml b/.github/workflows/static-code-scanning.yaml index 8e161d75..654d3fff 100644 --- a/.github/workflows/static-code-scanning.yaml +++ b/.github/workflows/static-code-scanning.yaml @@ -33,12 +33,12 @@ jobs: # Initializes the CodeQL tools for scanning. - name: Initialize CodeQL - uses: github/codeql-action/init@362ef4ce205154842cd1d34794abd82bb8f12cd5 + uses: github/codeql-action/init@d26c46acea4065b13fc57703621e0a7c8b9e836b with: languages: java - name: Autobuild - uses: github/codeql-action/autobuild@362ef4ce205154842cd1d34794abd82bb8f12cd5 + uses: github/codeql-action/autobuild@d26c46acea4065b13fc57703621e0a7c8b9e836b - name: Perform CodeQL Analysis - uses: github/codeql-action/analyze@362ef4ce205154842cd1d34794abd82bb8f12cd5 + uses: github/codeql-action/analyze@d26c46acea4065b13fc57703621e0a7c8b9e836b diff --git a/README.md b/README.md index 22d85bd2..8a577e6d 100644 --- a/README.md +++ b/README.md @@ -46,7 +46,7 @@ ### Requirements -- Java 8+ (compiler target is 1.8) +- Java 11+ (compiler target is 11) Note that this library is intended to be used in server-side contexts and has not been evaluated for use on mobile devices. diff --git a/pom.xml b/pom.xml index a725224c..7a7c0c67 100644 --- a/pom.xml +++ b/pom.xml @@ -10,7 +10,7 @@ [17,) UTF-8 - 1.8 + 11 ${maven.compiler.source} 5.12.1 7.22.0 @@ -20,7 +20,8 @@ ${project.groupId}.${project.artifactId} false - 8 + 11 + 1.18.38 OpenFeature Java SDK @@ -54,7 +55,7 @@ org.projectlombok lombok - 1.18.38 + ${lombok.version} provided @@ -263,6 +264,15 @@ maven-compiler-plugin 3.14.0 + + + + org.projectlombok + lombok + ${lombok.version} + + + @@ -473,7 +483,7 @@ com.diffplug.spotless spotless-maven-plugin - 2.44.3 + 2.44.4 @@ -646,14 +656,14 @@ - - + + - java8 + java11 - (1.8,9) + [11,) true diff --git a/spotbugs-exclusions.xml b/spotbugs-exclusions.xml index 66032ad0..5988a3a4 100644 --- a/spotbugs-exclusions.xml +++ b/spotbugs-exclusions.xml @@ -46,6 +46,11 @@ + + we can ignore return values of chainables (builders) here + + + @@ -58,4 +63,4 @@ - \ No newline at end of file + diff --git a/src/main/java/dev/openfeature/sdk/hooks/logging/LoggingHook.java b/src/main/java/dev/openfeature/sdk/hooks/logging/LoggingHook.java index 7465aa77..e6dc9b50 100644 --- a/src/main/java/dev/openfeature/sdk/hooks/logging/LoggingHook.java +++ b/src/main/java/dev/openfeature/sdk/hooks/logging/LoggingHook.java @@ -17,9 +17,6 @@ * Flag evaluation data is logged at debug and error in before/after stages and error stages, respectively. */ @Slf4j -@edu.umd.cs.findbugs.annotations.SuppressFBWarnings( - value = "RV_RETURN_VALUE_IGNORED", - justification = "we can ignore return values of chainables (builders) here") public class LoggingHook implements Hook { static final String DOMAIN_KEY = "domain"; diff --git a/src/main/java/module-info.java b/src/main/java/module-info.java new file mode 100644 index 00000000..0079cba0 --- /dev/null +++ b/src/main/java/module-info.java @@ -0,0 +1,10 @@ +module dev.openfeature.sdk { + requires static lombok; + requires org.slf4j; + requires com.github.spotbugs.annotations; + + exports dev.openfeature.sdk; + exports dev.openfeature.sdk.exceptions; + exports dev.openfeature.sdk.hooks.logging; + exports dev.openfeature.sdk.providers.memory; +}