feat: ISSUE-658 go-feature-flag sdk - add cache #369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data collector events Signed-off-by: liran2000 <liran2000@gmail.com>
thomaspoignant
requested changes
Jul 25, 2023
There was a problem hiding this comment.
@liran2000 thanks a lot for your contribution, this is really awesome, and I can't wait to have the cache in the JAVA provider 🙌.
I've done a first review pass and found some points that can be improved, let me know if you need any further information about them.
...ature-flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/bean/BeanUtils.java
Outdated
Show resolved
Hide resolved
...ature-flag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/bean/BeanUtils.java
Outdated
Show resolved
Hide resolved
...lag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java
Outdated
Show resolved
Hide resolved
.../main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProviderOptions.java
Outdated
Show resolved
Hide resolved
...lag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java
Outdated
Show resolved
Hide resolved
...lag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java
Outdated
Show resolved
Hide resolved
...lag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java
Outdated
Show resolved
Hide resolved
...lag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: liran2000 <liran2000@gmail.com>
- added events publish retry mechanism support - added shutdown Signed-off-by: liran2000 <liran2000@gmail.com>
…b/providers/gofeatureflag/bean/BeanUtils.java Signed-off-by: Thomas Poignant <thomas.poignant@gmail.com>
thomaspoignant
requested changes
Jul 28, 2023
There was a problem hiding this comment.
Hey, I've spotted some minor things here and there to fix some warnings.
The main thing we should tackle is that we should probably override the method initialize to initialize the collection in the background and to use fully the SDK capabilities.
For this what we may do is move the code from initializeProvider to initialize and remove the call from the constructor.
If we move the code there we will also have to implement the getStatus() method and have the provider status lifecycle ready in the provider.
I've done something similar in the node provider here if you want to have a look: open-feature/js-sdk-contrib#493
If you prefer, I'll be happy to help you with that myself and to collaborate on this pull request, but this up to you.
...lag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java
Outdated
Show resolved
Hide resolved
...lag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java
Outdated
Show resolved
Hide resolved
.../main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProviderOptions.java
Outdated
Show resolved
Hide resolved
...lag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java
Outdated
Show resolved
Hide resolved
...lag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java
Outdated
Show resolved
Hide resolved
...lag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java
Outdated
Show resolved
Hide resolved
...lag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java
Outdated
Show resolved
Hide resolved
...lag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: liran2000 <liran2000@gmail.com>
…nto go-feature-flag-provider-658d
…nitialized Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
8923a47 to
a9d27b5
Compare
liran2000
commented
Aug 3, 2023
There was a problem hiding this comment.
@thomaspoignant thanks for reviewing, please see my comments on the commit, as it affects the flow.
...lag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java
Outdated
Show resolved
Hide resolved
...lag/src/main/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProvider.java
Outdated
Show resolved
Hide resolved
...src/test/java/dev/openfeature/contrib/providers/gofeatureflag/GoFeatureFlagProviderTest.java
Show resolved
Hide resolved
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
76a2954 to
dc9ed21
Compare
thomaspoignant
approved these changes
Aug 7, 2023
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
af504c0 to
f02fd35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Implementing issue 658: (feature) Implement open-feature provider cache for the Java provider.
Related Issues
issue 658
Notes
How to test