Skip to content

chore: use keyword arguments, validate test #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2025
Merged

chore: use keyword arguments, validate test #446

merged 2 commits into from
Feb 13, 2025

Conversation

leohoare
Copy link
Contributor

This PR

Cleaning up some tech debt associated mentioned in this comment

  • Dynamically resolve based on keyword arguments
  • I wasn't able to find a configuration that worked on python 3.8/3.9 with mypy. I opted for ignoring the call-arg.
  • If we'd prefer not ignore the error and keep positional arguments, feel free to close the PR.

How to test

Standard testing (test, e2e, pre-commit)

@leohoare
use keyword arguments, validate test
0abff15 
Signed-off-by: leohoare <leo@insight.co>
@codecov Codecov
Copy link

codecov bot commented Feb 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (f907855) to head (82195f7).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage   97.71%   97.72%           
=======================================
  Files          32       32           
  Lines        1621     1623    +2     
=======================================
+ Hits         1584     1586    +2     
  Misses         37       37
Flag Coverage Δ
unittests 97.72% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@beeme1mr beeme1mr changed the title use keyword arguments, validate test chore: use keyword arguments, validate test Feb 12, 2025
lukas-reining
lukas-reining approved these changes Feb 13, 2025
View reviewed changes
Copy link
Member

@lukas-reining lukas-reining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left one question.

@beeme1mr beeme1mr merged commit f29c450 into open-feature:main Feb 13, 2025
14 checks passed
@openfeaturebot openfeaturebot mentioned this pull request Feb 12, 2025
Merged
@gruebel gruebel mentioned this pull request Feb 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

@aepfli aepfli aepfli approved these changes

@chrfwow chrfwow chrfwow approved these changes

@gruebel gruebel gruebel approved these changes

@lukas-reining lukas-reining lukas-reining approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@leohoare @beeme1mr @aepfli @chrfwow @gruebel @lukas-reining