From 0abff15e261dec15329db4d2f4cc552597fe0ae6 Mon Sep 17 00:00:00 2001
From: leohoare <leo@insight.co>
Date: Wed, 12 Feb 2025 21:36:55 +1100
Subject: [PATCH] use keyword arguments, validate test

Signed-off-by: leohoare <leo@insight.co>
---
 openfeature/client.py | 23 ++++++++++-------------
 tests/test_client.py  | 12 ++++++++++--
 2 files changed, 20 insertions(+), 15 deletions(-)

diff --git a/openfeature/client.py b/openfeature/client.py
index 7d1f26df..d73a3800 100644
--- a/openfeature/client.py
+++ b/openfeature/client.py
@@ -701,11 +701,6 @@ async def _create_provider_evaluation_async(
         default_value: typing.Any,
         evaluation_context: typing.Optional[EvaluationContext] = None,
     ) -> FlagEvaluationDetails[typing.Any]:
-        args = (
-            flag_key,
-            default_value,
-            evaluation_context,
-        )
         get_details_callables_async: typing.Mapping[
             FlagType, GetDetailCallableAsync
         ] = {
@@ -719,7 +714,11 @@ async def _create_provider_evaluation_async(
         if not get_details_callable:
             raise GeneralError(error_message="Unknown flag type")
 
-        resolution = await get_details_callable(*args)
+        resolution = await get_details_callable(  # type: ignore[call-arg]
+            flag_key=flag_key,
+            default_value=default_value,
+            evaluation_context=evaluation_context,
+        )
         resolution.raise_for_error()
 
         # we need to check the get_args to be compatible with union types.
@@ -753,12 +752,6 @@ def _create_provider_evaluation(
         :return: a FlagEvaluationDetails object with the fully evaluated flag from a
         provider
         """
-        args = (
-            flag_key,
-            default_value,
-            evaluation_context,
-        )
-
         get_details_callables: typing.Mapping[FlagType, GetDetailCallable] = {
             FlagType.BOOLEAN: provider.resolve_boolean_details,
             FlagType.INTEGER: provider.resolve_integer_details,
@@ -771,7 +764,11 @@ def _create_provider_evaluation(
         if not get_details_callable:
             raise GeneralError(error_message="Unknown flag type")
 
-        resolution = get_details_callable(*args)
+        resolution = get_details_callable(  # type: ignore[call-arg]
+            flag_key=flag_key,
+            default_value=default_value,
+            evaluation_context=evaluation_context,
+        )
         resolution.raise_for_error()
 
         # we need to check the get_args to be compatible with union types.
diff --git a/tests/test_client.py b/tests/test_client.py
index 5d333993..9264018d 100644
--- a/tests/test_client.py
+++ b/tests/test_client.py
@@ -526,12 +526,20 @@ def test_client_should_merge_contexts():
     invocation_context = EvaluationContext(
         targeting_key="invocation", attributes={"invocation_attr": "invocation_value"}
     )
-    client.get_boolean_details("flag", False, invocation_context)
+    flag_input = "flag"
+    flag_default = False
+    client.get_boolean_details(flag_input, flag_default, invocation_context)
 
     # Retrieve the call arguments
     args, kwargs = provider.resolve_boolean_details.call_args
-    flag_key, default_value, context = args
+    flag_key, default_value, context = (
+        kwargs["flag_key"],
+        kwargs["default_value"],
+        kwargs["evaluation_context"],
+    )
 
+    assert flag_key == flag_input
+    assert default_value is flag_default
     assert context.targeting_key == "invocation"  # Last one in the merge chain
     assert context.attributes["global_attr"] == "global_value"
     assert context.attributes["transaction_attr"] == "transaction_value"