Skip to content

Commit 045be9c

Browse files
perhapsmapleperhapsmaple
authored
[BUILD] DLL export interface for Metrics (#2344)
1 parent f16deb0 commit 045be9c

File tree

14 files changed

+112
-22
lines changed

14 files changed

+112
-22
lines changed

‎ci/do_ci.ps1

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ switch ($action) {
5858
cmake $SRC_DIR `
5959
-DVCPKG_TARGET_TRIPLET=x64-windows `
6060
-DOPENTELEMETRY_BUILD_DLL=1 `
61-
"-DCMAKE_TOOLCHAIN_FILE=$VCPKG_DIR/scripts/buildsystems/vcpkg.cmake"
61+
"-DCMAKE_TOOLCHAIN_FILE=$VCPKG_DIR/scripts/buildsystems/vcpkg.cmake"
6262
$exit = $LASTEXITCODE
6363
if ($exit -ne 0) {
6464
exit $exit
@@ -79,6 +79,16 @@ switch ($action) {
7979
if ($exit -ne 0) {
8080
exit $exit
8181
}
82+
examples\metrics_simple\Debug\metrics_ostream_example.exe
83+
$exit = $LASTEXITCODE
84+
if ($exit -ne 0) {
85+
exit $exit
86+
}
87+
examples\logs_simple\Debug\example_logs_simple.exe
88+
$exit = $LASTEXITCODE
89+
if ($exit -ne 0) {
90+
exit $exit
91+
}
8292
}
8393
"cmake.maintainer.test" {
8494
cd "$BUILD_DIR"

‎examples/common/metrics_foo_library/CMakeLists.txt

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,12 @@
11
# Copyright The OpenTelemetry Authors
22
# SPDX-License-Identifier: Apache-2.0
33

4+
if(DEFINED OPENTELEMETRY_BUILD_DLL)
5+
add_definitions(-DOPENTELEMETRY_BUILD_IMPORT_DLL)
6+
endif()
7+
48
add_library(common_metrics_foo_library foo_library.h foo_library.cc)
59
set_target_version(common_metrics_foo_library)
6-
target_link_libraries(common_metrics_foo_library PUBLIC opentelemetry_api)
10+
11+
target_link_libraries(common_metrics_foo_library
12+
PUBLIC ${CMAKE_THREAD_LIBS_INIT} opentelemetry_api)

‎examples/metrics_simple/CMakeLists.txt

Lines changed: 15 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,20 @@
11
# Copyright The OpenTelemetry Authors
22
# SPDX-License-Identifier: Apache-2.0
33

4+
if(DEFINED OPENTELEMETRY_BUILD_DLL)
5+
add_definitions(-DOPENTELEMETRY_BUILD_IMPORT_DLL)
6+
endif()
7+
48
include_directories(${CMAKE_SOURCE_DIR}/exporters/ostream/include)
9+
510
add_executable(metrics_ostream_example metrics_ostream.cc)
6-
target_link_libraries(
7-
metrics_ostream_example ${CMAKE_THREAD_LIBS_INIT} opentelemetry_metrics
8-
opentelemetry_exporter_ostream_metrics opentelemetry_resources
9-
common_metrics_foo_library)
11+
target_link_libraries(metrics_ostream_example ${CMAKE_THREAD_LIBS_INIT}
12+
common_metrics_foo_library)
13+
14+
if(DEFINED OPENTELEMETRY_BUILD_DLL)
15+
target_link_libraries(metrics_ostream_example opentelemetry_cpp)
16+
else()
17+
target_link_libraries(
18+
metrics_ostream_example opentelemetry_metrics
19+
opentelemetry_exporter_ostream_metrics opentelemetry_resources)
20+
endif()

‎examples/otlp/CMakeLists.txt

Lines changed: 20 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,15 @@ if(WITH_OTLP_GRPC)
2828

2929
add_executable(example_otlp_grpc_metric grpc_metric_main.cc)
3030

31-
target_link_libraries(
32-
example_otlp_grpc_metric ${CMAKE_THREAD_LIBS_INIT}
33-
common_metrics_foo_library opentelemetry_metrics
34-
opentelemetry_exporter_otlp_grpc_metrics)
31+
target_link_libraries(example_otlp_grpc_metric ${CMAKE_THREAD_LIBS_INIT}
32+
common_metrics_foo_library)
33+
34+
if(DEFINED OPENTELEMETRY_BUILD_DLL)
35+
target_link_libraries(example_otlp_grpc_metric opentelemetry_cpp)
36+
else()
37+
target_link_libraries(example_otlp_grpc_metric opentelemetry_metrics
38+
opentelemetry_exporter_otlp_grpc_metrics)
39+
endif()
3540

3641
# LOG
3742

@@ -66,10 +71,17 @@ if(WITH_OTLP_HTTP)
6671
# METRIC
6772

6873
add_executable(example_otlp_http_metric http_metric_main.cc)
69-
target_link_libraries(
70-
example_otlp_http_metric ${CMAKE_THREAD_LIBS_INIT}
71-
common_metrics_foo_library opentelemetry_metrics
72-
opentelemetry_exporter_otlp_http_metric)
74+
target_link_libraries(example_otlp_http_metric ${CMAKE_THREAD_LIBS_INIT}
75+
common_metrics_foo_library)
76+
77+
if(DEFINED OPENTELEMETRY_BUILD_DLL)
78+
target_link_libraries(example_otlp_http_metric opentelemetry_cpp
79+
opentelemetry_common)
80+
else()
81+
target_link_libraries(
82+
example_otlp_http_metric common_metrics_foo_library opentelemetry_metrics
83+
opentelemetry_exporter_otlp_http_metric)
84+
endif()
7385

7486
# LOG
7587

‎exporters/otlp/include/opentelemetry/exporters/otlp/otlp_grpc_metric_exporter_factory.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ namespace otlp
1515
/**
1616
* Factory class for OtlpGrpcMetricExporter.
1717
*/
18-
class OtlpGrpcMetricExporterFactory
18+
class OPENTELEMETRY_EXPORT OtlpGrpcMetricExporterFactory
1919
{
2020
public:
2121
/**

‎exporters/otlp/include/opentelemetry/exporters/otlp/otlp_http_metric_exporter_factory.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ namespace otlp
1717
/**
1818
* Factory class for OtlpHttpMetricExporter.
1919
*/
20-
class OtlpHttpMetricExporterFactory
20+
class OPENTELEMETRY_EXPORT OtlpHttpMetricExporterFactory
2121
{
2222
public:
2323
/**

‎ext/src/dll/CMakeLists.txt

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,20 @@ if(WITH_OTLP_HTTP)
2222
PRIVATE opentelemetry_exporter_otlp_http)
2323
endif()
2424

25+
target_link_libraries(
26+
opentelemetry_cpp PRIVATE opentelemetry_metrics
27+
opentelemetry_exporter_ostream_metrics)
28+
29+
if(WITH_OTLP_GRPC)
30+
target_link_libraries(opentelemetry_cpp
31+
PRIVATE opentelemetry_exporter_otlp_grpc_metrics)
32+
endif()
33+
34+
if(WITH_OTLP_HTTP)
35+
target_link_libraries(opentelemetry_cpp
36+
PRIVATE opentelemetry_exporter_otlp_http_metric)
37+
endif()
38+
2539
target_link_libraries(
2640
opentelemetry_cpp PRIVATE opentelemetry_logs
2741
opentelemetry_exporter_ostream_logs)

‎ext/src/dll/opentelemetry_cpp.src

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,15 +57,48 @@ EXPORTS
5757
?ForceFlush@TracerProvider@trace@sdk@v1@opentelemetry@@QEAA_NV?$duration@_JU?$ratio@$00$0PECEA@@std@@@chrono@std@@@Z
5858
?ForceFlush@LoggerProvider@logs@sdk@v1@opentelemetry@@QEAA_NV?$duration@_JU?$ratio@$00$0PECEA@@std@@@chrono@std@@@Z
5959
??0OStreamLogRecordExporter@logs@exporter@v1@opentelemetry@@QEAA@AEAV?$basic_ostream@DU?$char_traits@D@std@@@std@@@Z
60+
61+
// public: static class std::unique_ptr<class opentelemetry::v1::sdk::metrics::PushMetricExporter,struct std::default_delete<class opentelemetry::v1::sdk::metrics::PushMetricExporter> > __cdecl opentelemetry::v1::exporter::metrics::OStreamMetricExporterFactory::Create(void)
62+
?Create@OStreamMetricExporterFactory@metrics@exporter@v1@opentelemetry@@SA?AV?$unique_ptr@VPushMetricExporter@metrics@sdk@v1@opentelemetry@@U?$default_delete@VPushMetricExporter@metrics@sdk@v1@opentelemetry@@@std@@@std@@XZ
63+
// public: static class std::unique_ptr<class opentelemetry::v1::sdk::metrics::MetricReader,struct std::default_delete<class opentelemetry::v1::sdk::metrics::MetricReader> > __cdecl opentelemetry::v1::sdk::metrics::PeriodicExportingMetricReaderFactory::Create(class std::unique_ptr<class opentelemetry::v1::sdk::metrics::PushMetricExporter,struct std::default_delete<class opentelemetry::v1::sdk::metrics::PushMetricExporter> >,struct opentelemetry::v1::sdk::metrics::PeriodicExportingMetricReaderOptions const & __ptr64)
64+
?Create@PeriodicExportingMetricReaderFactory@metrics@sdk@v1@opentelemetry@@SA?AV?$unique_ptr@VMetricReader@metrics@sdk@v1@opentelemetry@@U?$default_delete@VMetricReader@metrics@sdk@v1@opentelemetry@@@std@@@std@@V?$unique_ptr@VPushMetricExporter@metrics@sdk@v1@opentelemetry@@U?$default_delete@VPushMetricExporter@metrics@sdk@v1@opentelemetry@@@std@@@7@AEBUPeriodicExportingMetricReaderOptions@2345@@Z
65+
// public: static class std::unique_ptr<class opentelemetry::v1::metrics::MeterProvider,struct std::default_delete<class opentelemetry::v1::metrics::MeterProvider> > __cdecl opentelemetry::v1::sdk::metrics::MeterProviderFactory::Create(void)
66+
?Create@MeterProviderFactory@metrics@sdk@v1@opentelemetry@@SA?AV?$unique_ptr@VMeterProvider@metrics@v1@opentelemetry@@U?$default_delete@VMeterProvider@metrics@v1@opentelemetry@@@std@@@std@@XZ
67+
// public: static class std::unique_ptr<class opentelemetry::v1::sdk::metrics::MeterContext,struct std::default_delete<class opentelemetry::v1::sdk::metrics::MeterContext> > __cdecl opentelemetry::v1::sdk::metrics::MeterContextFactory::Create(void)
68+
?Create@MeterContextFactory@metrics@sdk@v1@opentelemetry@@SA?AV?$unique_ptr@VMeterContext@metrics@sdk@v1@opentelemetry@@U?$default_delete@VMeterContext@metrics@sdk@v1@opentelemetry@@@std@@@std@@XZ
69+
// public: static class std::unique_ptr<class opentelemetry::v1::metrics::MeterProvider,struct std::default_delete<class opentelemetry::v1::metrics::MeterProvider> > __cdecl opentelemetry::v1::sdk::metrics::MeterProviderFactory::Create(class std::unique_ptr<class opentelemetry::v1::sdk::metrics::MeterContext,struct std::default_delete<class opentelemetry::v1::sdk::metrics::MeterContext> >)
70+
?Create@MeterProviderFactory@metrics@sdk@v1@opentelemetry@@SA?AV?$unique_ptr@VMeterProvider@metrics@v1@opentelemetry@@U?$default_delete@VMeterProvider@metrics@v1@opentelemetry@@@std@@@std@@V?$unique_ptr@VMeterContext@metrics@sdk@v1@opentelemetry@@U?$default_delete@VMeterContext@metrics@sdk@v1@opentelemetry@@@std@@@7@@Z
71+
// public: static class std::unique_ptr<class opentelemetry::v1::sdk::metrics::View,struct std::default_delete<class opentelemetry::v1::sdk::metrics::View> > __cdecl opentelemetry::v1::sdk::metrics::ViewFactory::Create(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,enum opentelemetry::v1::sdk::metrics::AggregationType,class std::shared_ptr<class opentelemetry::v1::sdk::metrics::AggregationConfig>)
72+
?Create@ViewFactory@metrics@sdk@v1@opentelemetry@@SA?AV?$unique_ptr@VView@metrics@sdk@v1@opentelemetry@@U?$default_delete@VView@metrics@sdk@v1@opentelemetry@@@std@@@std@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@7@00W4AggregationType@2345@V?$shared_ptr@VAggregationConfig@metrics@sdk@v1@opentelemetry@@@7@@Z
73+
// public: static class std::unique_ptr<class opentelemetry::v1::sdk::metrics::View,struct std::default_delete<class opentelemetry::v1::sdk::metrics::View> > __cdecl opentelemetry::v1::sdk::metrics::ViewFactory::Create(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,enum opentelemetry::v1::sdk::metrics::AggregationType)
74+
?Create@ViewFactory@metrics@sdk@v1@opentelemetry@@SA?AV?$unique_ptr@VView@metrics@sdk@v1@opentelemetry@@U?$default_delete@VView@metrics@sdk@v1@opentelemetry@@@std@@@std@@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@7@00W4AggregationType@2345@@Z
75+
// public: static class std::unique_ptr<class opentelemetry::v1::sdk::metrics::MeterSelector,struct std::default_delete<class opentelemetry::v1::sdk::metrics::MeterSelector> > __cdecl opentelemetry::v1::sdk::metrics::MeterSelectorFactory::Create(class opentelemetry::v1::nostd::string_view,class opentelemetry::v1::nostd::string_view,class opentelemetry::v1::nostd::string_view)
76+
?Create@MeterSelectorFactory@metrics@sdk@v1@opentelemetry@@SA?AV?$unique_ptr@VMeterSelector@metrics@sdk@v1@opentelemetry@@U?$default_delete@VMeterSelector@metrics@sdk@v1@opentelemetry@@@std@@@std@@Vstring_view@nostd@45@00@Z
77+
// public: static class std::unique_ptr<class opentelemetry::v1::sdk::metrics::InstrumentSelector,struct std::default_delete<class opentelemetry::v1::sdk::metrics::InstrumentSelector> > __cdecl opentelemetry::v1::sdk::metrics::InstrumentSelectorFactory::Create(enum opentelemetry::v1::sdk::metrics::InstrumentType,class opentelemetry::v1::nostd::string_view,class opentelemetry::v1::nostd::string_view)
78+
?Create@InstrumentSelectorFactory@metrics@sdk@v1@opentelemetry@@SA?AV?$unique_ptr@VInstrumentSelector@metrics@sdk@v1@opentelemetry@@U?$default_delete@VInstrumentSelector@metrics@sdk@v1@opentelemetry@@@std@@@std@@W4InstrumentType@2345@Vstring_view@nostd@45@1@Z
79+
80+
// public: void __cdecl opentelemetry::v1::sdk::metrics::MeterContext::AddMetricReader(class std::shared_ptr<class opentelemetry::v1::sdk::metrics::MetricReader>)
81+
?AddMetricReader@MeterContext@metrics@sdk@v1@opentelemetry@@QEAAXV?$shared_ptr@VMetricReader@metrics@sdk@v1@opentelemetry@@@std@@@Z
82+
// public: void __cdecl opentelemetry::v1::sdk::metrics::MeterProvider::AddMetricReader(class std::shared_ptr<class opentelemetry::v1::sdk::metrics::MetricReader>)
83+
?AddMetricReader@MeterProvider@metrics@sdk@v1@opentelemetry@@QEAAXV?$shared_ptr@VMetricReader@metrics@sdk@v1@opentelemetry@@@std@@@Z
84+
// public: void __cdecl opentelemetry::v1::sdk::metrics::MeterProvider::AddView(class std::unique_ptr<class opentelemetry::v1::sdk::metrics::InstrumentSelector,struct std::default_delete<class opentelemetry::v1::sdk::metrics::InstrumentSelector> >,class std::unique_ptr<class opentelemetry::v1::sdk::metrics::MeterSelector,struct std::default_delete<class opentelemetry::v1::sdk::metrics::MeterSelector> >,class std::unique_ptr<class opentelemetry::v1::sdk::metrics::View,struct std::default_delete<class opentelemetry::v1::sdk::metrics::View> >)
85+
?AddView@MeterProvider@metrics@sdk@v1@opentelemetry@@QEAAXV?$unique_ptr@VInstrumentSelector@metrics@sdk@v1@opentelemetry@@U?$default_delete@VInstrumentSelector@metrics@sdk@v1@opentelemetry@@@std@@@std@@V?$unique_ptr@VMeterSelector@metrics@sdk@v1@opentelemetry@@U?$default_delete@VMeterSelector@metrics@sdk@v1@opentelemetry@@@std@@@7@V?$unique_ptr@VView@metrics@sdk@v1@opentelemetry@@U?$default_delete@VView@metrics@sdk@v1@opentelemetry@@@std@@@7@@Z
86+
87+
6088
#if defined(WITH_OTLP_GRPC) || defined(WITH_OTLP_HTTP)
6189
?GetOtlpDefaultTracesTimeout@otlp@exporter@v1@opentelemetry@@YA?AV?$duration@_JU?$ratio@$00$0JIJGIA@@std@@@chrono@std@@XZ
6290
?GetOtlpDefaultTracesHeaders@otlp@exporter@v1@opentelemetry@@YA?AV?$multimap@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V12@Ucmp_ic@otlp@exporter@v1@opentelemetry@@V?$allocator@U?$pair@$$CBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V12@@std@@@2@@std@@XZ
6391
?GetOtlpDefaultLogsTimeout@otlp@exporter@v1@opentelemetry@@YA?AV?$duration@_JU?$ratio@$00$0JIJGIA@@std@@@chrono@std@@XZ
6492
?GetOtlpDefaultLogsHeaders@otlp@exporter@v1@opentelemetry@@YA?AV?$multimap@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V12@Ucmp_ic@otlp@exporter@v1@opentelemetry@@V?$allocator@U?$pair@$$CBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V12@@std@@@2@@std@@XZ
93+
?GetOtlpDefaultMetricsTimeout@otlp@exporter@v1@opentelemetry@@YA?AV?$duration@_JU?$ratio@$00$0JIJGIA@@std@@@chrono@std@@XZ
94+
?GetOtlpDefaultMetricsHeaders@otlp@exporter@v1@opentelemetry@@YA?AV?$multimap@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V12@Ucmp_ic@otlp@exporter@v1@opentelemetry@@V?$allocator@U?$pair@$$CBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@V12@@std@@@2@@std@@XZ
6595
#endif // defined(WITH_OTLP_GRPC) || defined(WITH_OTLP_HTTP)
6696
#if defined(WITH_OTLP_GRPC)
6797
// public: static class std::unique_ptr<class opentelemetry::v1::sdk::logs::LogRecordExporter,struct std::default_delete<class opentelemetry::v1::sdk::logs::LogRecordExporter> > __cdecl opentelemetry::v1::exporter::otlp::OtlpGrpcLogRecordExporterFactory::Create(struct opentelemetry::v1::exporter::otlp::OtlpGrpcExporterOptions const & __ptr64)
6898
?Create@OtlpGrpcLogRecordExporterFactory@otlp@exporter@v1@opentelemetry@@SA?AV?$unique_ptr@VLogRecordExporter@logs@sdk@v1@opentelemetry@@U?$default_delete@VLogRecordExporter@logs@sdk@v1@opentelemetry@@@std@@@std@@AEBUOtlpGrpcExporterOptions@2345@@Z
99+
// public: static class std::unique_ptr<class opentelemetry::v1::sdk::metrics::PushMetricExporter,struct std::default_delete<class opentelemetry::v1::sdk::metrics::PushMetricExporter> > __cdecl opentelemetry::v1::exporter::otlp::OtlpGrpcMetricExporterFactory::Create(struct opentelemetry::v1::exporter::otlp::OtlpGrpcMetricExporterOptions const & __ptr64)
100+
?Create@OtlpGrpcMetricExporterFactory@otlp@exporter@v1@opentelemetry@@SA?AV?$unique_ptr@VPushMetricExporter@metrics@sdk@v1@opentelemetry@@U?$default_delete@VPushMetricExporter@metrics@sdk@v1@opentelemetry@@@std@@@std@@AEBUOtlpGrpcMetricExporterOptions@2345@@Z
101+
69102
?GetOtlpDefaultGrpcTracesEndpoint@otlp@exporter@v1@opentelemetry@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@XZ
70103
?GetOtlpDefaultGrpcTracesIsInsecure@otlp@exporter@v1@opentelemetry@@YA_NXZ
71104
?GetOtlpDefaultTracesSslCertificatePath@otlp@exporter@v1@opentelemetry@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@XZ
@@ -76,5 +109,9 @@ EXPORTS
76109
?Create@OtlpHttpLogRecordExporterFactory@otlp@exporter@v1@opentelemetry@@SA?AV?$unique_ptr@VLogRecordExporter@logs@sdk@v1@opentelemetry@@U?$default_delete@VLogRecordExporter@logs@sdk@v1@opentelemetry@@@std@@@std@@AEBUOtlpHttpLogRecordExporterOptions@2345@@Z
77110
?GetOtlpDefaultHttpTracesEndpoint@otlp@exporter@v1@opentelemetry@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@XZ
78111
?GetOtlpDefaultHttpLogsEndpoint@otlp@exporter@v1@opentelemetry@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@XZ
112+
113+
// public: static class std::unique_ptr<class opentelemetry::v1::sdk::metrics::PushMetricExporter,struct std::default_delete<class opentelemetry::v1::sdk::metrics::PushMetricExporter> > __cdecl opentelemetry::v1::exporter::otlp::OtlpHttpMetricExporterFactory::Create(struct opentelemetry::v1::exporter::otlp::OtlpHttpMetricExporterOptions const &)
114+
?Create@OtlpHttpMetricExporterFactory@otlp@exporter@v1@opentelemetry@@SA?AV?$unique_ptr@VPushMetricExporter@metrics@sdk@v1@opentelemetry@@U?$default_delete@VPushMetricExporter@metrics@sdk@v1@opentelemetry@@@std@@@std@@AEBUOtlpHttpMetricExporterOptions@2345@@Z
115+
?GetOtlpDefaultHttpMetricsEndpoint@otlp@exporter@v1@opentelemetry@@YA?AV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@XZ
79116
#endif // defined(WITH_OTLP_HTTP)
80117
// clang-format on

‎sdk/include/opentelemetry/sdk/metrics/export/periodic_exporting_metric_reader_factory.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ namespace metrics
1616
class MetricReader;
1717
class PushMetricExporter;
1818

19-
class PeriodicExportingMetricReaderFactory
19+
class OPENTELEMETRY_EXPORT PeriodicExportingMetricReaderFactory
2020
{
2121
public:
2222
static std::unique_ptr<MetricReader> Create(std::unique_ptr<PushMetricExporter> exporter,

‎sdk/include/opentelemetry/sdk/metrics/meter_context_factory.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ class ViewRegistry;
2121
/**
2222
* Factory class for MeterContext.
2323
*/
24-
class MeterContextFactory
24+
class OPENTELEMETRY_EXPORT MeterContextFactory
2525
{
2626
public:
2727
/**

0 commit comments

Comments
 (0)