[EXPORTER] All 2xx return codes should be considered successful. (#2712)

owent · web-flow · commit 4e86a86a5fbb · 2024-06-21T11:14:09.000+02:00
diff --git a/exporters/elasticsearch/src/es_log_record_exporter.cc b/exporters/elasticsearch/src/es_log_record_exporter.cc
@@ -59,7 +59,7 @@ class ResponseHandler : public http_client::EventHandler
       // Store the body of the request
       body_ = std::string(response.GetBody().begin(), response.GetBody().end());
 
-      if (response.GetStatusCode() != 200 && response.GetStatusCode() != 202)
+      if (!(response.GetStatusCode() >= 200 && response.GetStatusCode() <= 299))
       {
         log_message = BuildResponseLogMessage(response, body_);
 
diff --git a/exporters/otlp/src/otlp_http_client.cc b/exporters/otlp/src/otlp_http_client.cc
@@ -100,7 +100,7 @@ class ResponseHandler : public http_client::EventHandler
       // Store the body of the request
       body_ = std::string(response.GetBody().begin(), response.GetBody().end());
 
-      if (response.GetStatusCode() != 200 && response.GetStatusCode() != 202)
+      if (!(response.GetStatusCode() >= 200 && response.GetStatusCode() <= 299))
       {
         log_message = BuildResponseLogMessage(response, body_);
 
diff --git a/exporters/zipkin/src/zipkin_exporter.cc b/exporters/zipkin/src/zipkin_exporter.cc
@@ -78,7 +78,7 @@ sdk::common::ExportResult ZipkinExporter::Export(
   http_client::Body body_v(body_s.begin(), body_s.end());
   auto result = http_client_->PostNoSsl(url_parser_.url_, body_v, options_.headers);
   if (result &&
-      (result.GetResponse().GetStatusCode() == 200 || result.GetResponse().GetStatusCode() == 202))
+      (result.GetResponse().GetStatusCode() >= 200 && result.GetResponse().GetStatusCode() <= 299))
   {
     return sdk::common::ExportResult::kSuccess;
   }

Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ class ResponseHandler : public http_client::EventHandler`
`59`	`59`	`// Store the body of the request`
`60`	`60`	`body_ = std::string(response.GetBody().begin(), response.GetBody().end());`
`61`	`61`
`62`		`- if (response.GetStatusCode() != 200 && response.GetStatusCode() != 202)`
	`62`	`+ if (!(response.GetStatusCode() >= 200 && response.GetStatusCode() <= 299))`
`63`	`63`	`{`
`64`	`64`	`log_message = BuildResponseLogMessage(response, body_);`
`65`	`65`
Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ class ResponseHandler : public http_client::EventHandler`
`100`	`100`	`// Store the body of the request`
`101`	`101`	`body_ = std::string(response.GetBody().begin(), response.GetBody().end());`
`102`	`102`
`103`		`- if (response.GetStatusCode() != 200 && response.GetStatusCode() != 202)`
	`103`	`+ if (!(response.GetStatusCode() >= 200 && response.GetStatusCode() <= 299))`
`104`	`104`	`{`
`105`	`105`	`log_message = BuildResponseLogMessage(response, body_);`
`106`	`106`
Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ sdk::common::ExportResult ZipkinExporter::Export(`
`78`	`78`	`http_client::Body body_v(body_s.begin(), body_s.end());`
`79`	`79`	`auto result = http_client_->PostNoSsl(url_parser_.url_, body_v, options_.headers);`
`80`	`80`	`if (result &&`
`81`		`- (result.GetResponse().GetStatusCode() == 200 \|\| result.GetResponse().GetStatusCode() == 202))`
	`81`	`+ (result.GetResponse().GetStatusCode() >= 200 && result.GetResponse().GetStatusCode() <= 299))`
`82`	`82`	`{`
`83`	`83`	`return sdk::common::ExportResult::kSuccess;`
`84`	`84`	`}`