Fix memory leak in TlsRandomNumberGenerator() constructor #2660

hongweipeng · hongweipeng · commit 9ebc698efe33 · 2024-05-08T11:31:55.000+08:00
diff --git a/sdk/src/common/random.cc b/sdk/src/common/random.cc
@@ -5,6 +5,7 @@
 #include "src/common/random.h"
 #include "src/common/platform/fork.h"
 
+#include <atomic>
 #include <cstring>
 #include <random>
 
@@ -26,12 +27,17 @@ class TlsRandomNumberGenerator
   TlsRandomNumberGenerator() noexcept
   {
     Seed();
-    platform::AtFork(nullptr, nullptr, OnFork);
+    if (!flag.test_and_set())
+    {
+      platform::AtFork(nullptr, nullptr, OnFork);
+    }
   }
 
   static FastRandomNumberGenerator &engine() noexcept { return engine_; }
 
 private:
+  static std::atomic_flag flag;
+
   static thread_local FastRandomNumberGenerator engine_;
 
   static void OnFork() noexcept { Seed(); }
@@ -44,6 +50,7 @@ class TlsRandomNumberGenerator
   }
 };
 
+std::atomic_flag TlsRandomNumberGenerator::flag;
 thread_local FastRandomNumberGenerator TlsRandomNumberGenerator::engine_{};
 }  // namespace
 
