Skip to content

Fix Resource constructor examples #4554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
xrmx opened this issue Apr 17, 2025 · 2 comments
Open

Fix Resource constructor examples #4554

xrmx opened this issue Apr 17, 2025 · 2 comments
Labels
good first issue Good first issue

Comments

@xrmx
Copy link
Contributor

xrmx commented Apr 17, 2025

We have in comments and in code wrong example of Resource construction. The final resource sent to tracers, meters and loggers should be created with Resource.create and not by instantiating a Resource instance. In tests we may be more lenient since we don't care much what's there but in examples it should be correct.

See open-telemetry/opentelemetry.io#6549
@xrmx xrmx added the good first issue Good first issue label Apr 17, 2025
@xrmx xrmx changed the title Fix Resource constructors examples Fix Resource constructor examples Apr 17, 2025
@petertamuk
Copy link

Hi. I'd like to work on this issue. Please assign it to me. Thanks

@Sanket-0510
Copy link

Hi @xrmx, I’m interested in contributing and noticed this issue hasn’t had recent activity. If the current assignee is no longer working on it, I’d be glad to take it up and open a PR soon. Please let me know. Thanks!

@Sanket-0510 Sanket-0510 mentioned this issue May 10, 2025
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xrmx @petertamuk @Sanket-0510