Skip to content

Investigate async force flush approach for spanprocessors. #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
toumorokoshi opened this issue Jun 6, 2020 · 3 comments
Closed

Investigate async force flush approach for spanprocessors. #783

toumorokoshi opened this issue Jun 6, 2020 · 3 comments
Labels
backlog discussion Issue or PR that needs/is extended discussion.

Comments

@toumorokoshi
Copy link
Member

As part of #594, work was done to introduce two different MultiSpanProcessors: sync and async. Async uses a thread pool to be asynchronous.

@mauriciovasquezbernal argues that we may want to instead allow the caller to choose what sort of concurrency behavior to ask of the span processor (introducing a flush_force_async method):

#594 (comment)

Add this issue to discuss, and allow the PR to be merged in.

@toumorokoshi toumorokoshi added the discussion Issue or PR that needs/is extended discussion. label Jun 6, 2020
@lzchen
Copy link
Contributor

lzchen commented Jun 8, 2020

From a user standpoint, what does this new proposed approach entail? Post [#594], users would instantiate either the sync or async spanprocessor. Is the proposed change to instead expose an API call to either force flush sync/async, and then use the appropriate spanprocessor behind the scenes?

To bring up @mauriciovasquezbernal 's point, should we really have concurrency implemented in the MultiSpanProcessor level as opposed to individual spanprocessors themselves? An argument for this would be control to the implementor (for any custom spanprocessors they might want to implement) and lets them decide themselves whether or not to block. An argument against would be if we believe that our SDK should NEVER block, and let the concurrency/nonconcurrent controls be the responsibility of the sdk itself. In that case should all spanprocessors implemented be inherently synchronous since the control is left to the SDK?

@github-actions
Copy link

github-actions bot commented Apr 9, 2021

This issue was marked stale due to lack of activity. It will be closed in 30 days.

@github-actions
Copy link

github-actions bot commented Jun 8, 2021

Closed as inactive. Feel free to reopen if this issue needs resolving.

@github-actions github-actions bot closed this as completed Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog discussion Issue or PR that needs/is extended discussion.
Projects
None yet
Development

No branches or pull requests

2 participants