LLM: rename Runner execution methods to use leading underscores

pakrym-oai · pakrym-oai · commit 2002dd9b525a · 2025-05-19T18:05:20.000-07:00
This commit renames the abstract and concrete methods run_impl, run_sync_impl, and run_streamed_impl in the Runner and DefaultRunner classes to _run_impl, _run_sync_impl, and _run_streamed_impl (or _start_streaming as appropriate) for improved naming consistency. Updates all method calls and test mocks accordingly. No behavior changes.
diff --git a/src/agents/run.py b/src/agents/run.py
@@ -118,7 +118,7 @@ class RunConfig:
 
 class Runner(abc.ABC):
     @abc.abstractmethod
-    async def run_impl(
+    async def _run_impl(
         self,
         starting_agent: Agent[TContext],
         input: str | list[TResponseInputItem],
@@ -132,7 +132,7 @@ async def run_impl(
         pass
 
     @abc.abstractmethod
-    def run_sync_impl(
+    def _run_sync_impl(
         self,
         starting_agent: Agent[TContext],
         input: str | list[TResponseInputItem],
@@ -146,7 +146,7 @@ def run_sync_impl(
         pass
 
     @abc.abstractmethod
-    def run_streamed_impl(
+    def _run_streamed_impl(
         self,
         starting_agent: Agent[TContext],
         input: str | list[TResponseInputItem],
@@ -197,7 +197,7 @@ async def run(
             agent. Agents may perform handoffs, so we don't know the specific type of the output.
         """
         runner = DEFAULT_RUNNER or DefaultRunner()
-        return await runner.run_impl(
+        return await runner._run_impl(
             starting_agent,
             input,
             context=context,
@@ -249,7 +249,7 @@ def run_sync(
             agent. Agents may perform handoffs, so we don't know the specific type of the output.
         """
         runner = DEFAULT_RUNNER or DefaultRunner()
-        return runner.run_sync_impl(
+        return runner._run_sync_impl(
             starting_agent,
             input,
             context=context,
@@ -297,7 +297,7 @@ def run_streamed(
             A result object that contains data about the run, as well as a method to stream events.
         """
         runner = DEFAULT_RUNNER or DefaultRunner()
-        return runner.run_streamed_impl(
+        return runner._run_streamed_impl(
             starting_agent,
             input,
             context=context,
@@ -339,7 +339,7 @@ def _get_model(cls, agent: Agent[Any], run_config: RunConfig) -> Model:
 
 
 class DefaultRunner(Runner):
-    async def run_impl(
+    async def _run_impl(
         self,
         starting_agent: Agent[TContext],
         input: str | list[TResponseInputItem],
@@ -488,7 +488,7 @@ async def run_impl(
                 if current_span:
                     current_span.finish(reset_current=True)
 
-    def run_sync_impl(
+    def _run_sync_impl(
         self,
         starting_agent: Agent[TContext],
         input: str | list[TResponseInputItem],
@@ -511,7 +511,7 @@ def run_sync_impl(
             )
         )
 
-    def run_streamed_impl(
+    def _run_streamed_impl(
         self,
         starting_agent: Agent[TContext],
         input: str | list[TResponseInputItem],
@@ -564,7 +564,7 @@ def run_streamed_impl(
 
         # Kick off the actual agent loop in the background and return the streamed result object.
         streamed_result._run_impl_task = asyncio.create_task(
-            self._run_streamed_impl(
+            self._start_streaming(
                 starting_input=input,
                 streamed_result=streamed_result,
                 starting_agent=starting_agent,
@@ -621,7 +621,7 @@ async def _run_input_guardrails_with_queue(
         streamed_result.input_guardrail_results = guardrail_results
 
     @classmethod
-    async def _run_streamed_impl(
+    async def _start_streaming(
         cls,
         starting_input: str | list[TResponseInputItem],
         streamed_result: RunResultStreaming,
diff --git a/tests/test_run.py b/tests/test_run.py
@@ -17,10 +17,10 @@ async def test_static_run_methods_call_into_default_runner() -> None:
 
     agent = Agent(name="test", model=FakeModel())
     await Runner.run(agent, input="test")
-    runner.run_impl.assert_called_once()
+    runner._run_impl.assert_called_once()
 
     Runner.run_streamed(agent, input="test")
-    runner.run_streamed_impl.assert_called_once()
+    runner._run_streamed_impl.assert_called_once()
 
     Runner.run_sync(agent, input="test")
-    runner.run_sync_impl.assert_called_once()
+    runner._run_sync_impl.assert_called_once()
