Skip to content

the same isinstance(output, ResponseFunctionToolCall) check twice in "_run_impl.py " #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
beston123 opened this issue May 7, 2025 · 0 comments
Open

the same isinstance(output, ResponseFunctionToolCall) check twice in "_run_impl.py " #658

beston123 opened this issue May 7, 2025 · 0 comments

Comments

@beston123
Copy link

The code performs the same isinstance(output, ResponseFunctionToolCall) check twice. This is redundant and may confuse future maintainers or introduce unnecessary complexity.

openai-agents-python/src/agents/_run_impl.py

Line 378 in f976349

elif not isinstance(output, ResponseFunctionToolCall): 

           elif not isinstance(output, ResponseFunctionToolCall):
                logger.warning(f"Unexpected output type, ignoring: {type(output)}")
                continue

            # At this point we know it's a function tool call
            if not isinstance(output, ResponseFunctionToolCall):
                continue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@beston123