-
Notifications
You must be signed in to change notification settings - Fork 895
Add support for Python 3.7 #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yes, I will definetely add support for 3.7. However, there are a few things which need to be checked or updated before it is possible:
I can make the changes but the timetable for a new |
Just a few notes:
|
Thanks. Numpy's 3.7 wheels were released a bit after I wrote that message. Travis doesn't need to support 3.7 on Linux, the builds run in manylinux Docker containers which will have support for 3.7 after I rebuild them. macOS is ok if multibuild README says so. I'll make the required changes after Appeyor has added Python 3.7. |
On running : python setup.py install I get :
|
Update/bump: Appveyor now includes Python 3.7.0 @rose-maria I don't think this is the place for your own bug report (you might want to make a separate issue for that), but I could not reproduce that error. Does |
@yonip Thanks, I'll add support for 3.7 during this week, probably tomorrow. @rose-maria As suggested above, open a new issue if you think that the error is related to this repository (note: building this package locally has not been tested but it might work on Windows). |
Windows and Linux builds work fine but there's compiler compatibility issue on macOS due to upgrade to OpenCV 3.4.2:
Based on googling (https://stackoverflow.com/a/29929949/5795428) Xcode 8 should have support for thread-local storage but unfortunately the error persists with Xcode 8 and Xcode 9 environments in Travis. This is something which needs to be solved before I can make a new release. |
Thanks for your continued excellent work on this. For those wanting to see the Xcode errors, here are the opencv-python Travis-CI build logs |
This comment has been minimized.
This comment has been minimized.
Good news: after multiple failed builds with different parameters and with awesome help from @yonip the macOS builds are now working. After the current builds are done, I'll release a new version. It will be available on PyPI at the latest on monday. |
Release builds are now running and new packages will be available during the next 24 hours. |
I am having some issues fetching the latest version when using Python3.7 - I can reproduce it with the following Dockerfile:
Looking at the wheel files, it seems that the x86_64 wheel for py37 is missing. |
Looks like I have made some mistakes in the build matrix... only i686 entries are there for Linux :/ I'll have to make a new release. It will take couple of days because I'm simply running out of hours. It would help if someone could add the entries to the build matrix and submit a PR. I'll then make the release. |
Hey, are the x86_64 PyPI wheels going to be up soon? |
Just tagged a new version, they will be slowly appearing to PyPI. Thanks for the patience. |
The Linux x86_64 wheels for Python 3.7 are now on PyPi |
Hi there, we've noticed trying to upgrade our Python version to 3.7 that there is no way to install
opencv-python
with it. Would you consider adding it to the build matrice? Would you like a PR for that?Thanks for the great work 👌
The text was updated successfully, but these errors were encountered: