chore: fix version check in tests (#414)

ascorbic · web-flow · commit 31776a3ea653 · 2024-04-17T16:18:38.000+02:00
* chore: fix version check in tests

* chore: correct logic for writing version
diff --git a/tests/integration/simple-app.test.ts b/tests/integration/simple-app.test.ts
@@ -21,7 +21,6 @@ import {
   startMockBlobStore,
 } from '../utils/helpers.js'
 import { getPatchesToApply } from '../../src/build/content/server.js'
-import { nextVersionSatisfies } from '../utils/next-version-helpers.mjs'
 
 const mockedCp = cp as Mock<
   Parameters<(typeof import('node:fs/promises'))['cp']>,
@@ -218,7 +217,7 @@ test<FixtureTestContext>('rewrites to external addresses dont use compression',
   expect(gunzipSync(page.bodyBuffer).toString('utf-8')).toContain('<title>Example Domain</title>')
 })
 
-test.skipIf(!nextVersionSatisfies('canary'))<FixtureTestContext>(
+test.skipIf(process.env.NEXT_VERSION !== 'canary')<FixtureTestContext>(
   'Test that a simple next app with PPR is working',
   async (ctx) => {
     await createFixture('ppr', ctx)
diff --git a/tests/utils/next-version-helpers.mjs b/tests/utils/next-version-helpers.mjs
@@ -67,6 +67,7 @@ export async function setNextVersionInFixture(
         // We can't use semver to check "canary" or "latest", so we use a fake future minor version
         const checkVersion = isSemverVersion ? version : FUTURE_NEXT_PATCH_VERSION
         if (
+          operation === 'update' &&
           versionConstraint &&
           !satisfies(checkVersion, versionConstraint) &&
           version !== versionConstraint
