Merge pull request #46 from netlify/feat/next-version-check

ehmicky · web-flow · commit 3428aafbb606 · 2020-11-17T12:03:59.000-08:00
Validate Next.js version
diff --git a/helpers/validateNextUsage.js b/helpers/validateNextUsage.js
@@ -1,3 +1,6 @@
+const { lt: ltVersion, gte: gteVersion } = require('semver')
+const { yellowBright } = require('chalk')
+
 // Ensure Next.js is available.
 // We use `peerDependencies` instead of `dependencies` so that users can choose
 // the Next.js version. However, this requires them to install "next" in their
@@ -8,8 +11,24 @@ const validateNextUsage = function (failBuild) {
       'This site does not seem to be using Next.js. Please run "npm install next" or "yarn next" in the repository.',
     )
   }
+
+  // Old Next.js versions are not supported
+  const { version } = require('next/package.json')
+  if (ltVersion(version, MIN_VERSION)) {
+    return failBuild(`Please upgrade to Next.js ${MIN_VERSION} or later`)
+  }
+
+  // Recent Next.js versions are sometimes unstable and we might not officially
+  // support them yet. However, they might still work for some users, so we
+  // only print a warning
+  if (gteVersion(version, MIN_EXPERIMENTAL_VERSION)) {
+    console.log(yellowBright(`** Warning: support for Next.js >=${MIN_EXPERIMENTAL_VERSION} is experimental **`))
+  }
 }
 
+const MIN_VERSION = '9.5.3'
+const MIN_EXPERIMENTAL_VERSION = '10.0.0'
+
 const hasPackage = function (packageName) {
   try {
     require(packageName)
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -24,10 +24,12 @@
   },
   "homepage": "https://github.com/netlify/netlify-plugin-nextjs#readme",
   "dependencies": {
+    "chalk": "^4.1.0",
     "cpx": "^1.5.0",
     "find-up": "^4.1.0",
     "make-dir": "^3.1.0",
-    "next-on-netlify": "^2.6.0"
+    "next-on-netlify": "^2.6.0",
+    "semver": "^7.3.2"
   },
   "devDependencies": {
     "@netlify/eslint-config-node": "^0.3.0",
