Skip to content

chore: Add extensive test cases (e2e) #839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
14 of 19 tasks
tiffafoo opened this issue Nov 24, 2021 · 6 comments
Closed
14 of 19 tasks

chore: Add extensive test cases (e2e) #839

tiffafoo opened this issue Nov 24, 2021 · 6 comments
Labels
priority: low reliability code to address reliability issues type: chore work needed to keep the product and development running smoothly v4 Issues related to the v4 Next.js runtime

Comments

@tiffafoo
Copy link

tiffafoo commented Nov 24, 2021 •
edited by orinokai
Loading

Parent issue to keep track of all test cases/sites we want to have covered via Cypress. We will want to test most features of Next to ensure we don't break anything. Feel free to add more test cases.

Default site

This is the main demo site that represents simple use cases of various features of Next

  • basePath
  • Preview mode
  • i18n
  • Headers
  • Rewrites/redirects
  • basePath + i18n
  • Trailing slash
  • Catch-all/optional catch-all, getxxprops
  • Images
  • Dynamic imports
  • Custom 404/500
  • Static assets in public
  • cookie header locale
  • middleware (and on edge runtime fix: run edge middleware on data requests #1382)
  • advanced rewrite rules
  • react server components

Monorepo site

This represents a monorepo with sites deployed from it and some more advanced configuration

  • Custom dist
  • Monorepo: next run in root with site root in subdirectory

Nx site

This represents a site using Nx (monorepo)

  • nx create-app
@tiffafoo tiffafoo added the type: chore work needed to keep the product and development running smoothly label Nov 24, 2021
@tiffafoo tiffafoo self-assigned this Nov 24, 2021
This was referenced Nov 24, 2021
Merged
Merged
@tiffafoo tiffafoo mentioned this issue Dec 9, 2021
Merged
2 tasks
@nickytonline
Copy link

@tiffanosaurus, I'm going to go ahead and remove you from this as you've switched teams. Whoever picks this up, there's still some E2E tests to complete.

@nickytonline
Copy link

Hi @netlify/frameworks! We've been working on the Next.js plugin quite a bit lately. Just wondering if any of that work involved E2E tests for the middleware and advanced rewrite rules?

@orinokai
Copy link
Contributor

Hey @nickytonline, no afaik we haven't added tests yet for those features. I'm hoping to chat to Erica later this week about a few testing things so I'll roll this into it.

@orinokai orinokai self-assigned this May 11, 2022
@MarcL
Copy link
Contributor

MarcL commented Jun 27, 2022

@orinokai - Where are we at with this work? I was wondering if it's worth splitting this up into more manageable tickets if there's lots left to do.

@nickytonline nickytonline changed the title [Chore]: Add extensive test cases (e2e) chore: Add extensive test cases (e2e) Jun 27, 2022
@orinokai
Copy link
Contributor

orinokai commented Jul 5, 2022

I had planned to give the tests a good review after I finished the fallback work because the tests would need to be updated, but both aspects of that work are currently blocked and they should probably be a separate issue once the work is complete away. I'll make a start on this ticket this week.

This was referenced Jul 12, 2022
Closed
Closed
@orinokai orinokai removed their assignment Sep 26, 2022
@MarcL MarcL added the reliability code to address reliability issues label Jun 2, 2023
@MarcL MarcL added v4 Issues related to the v4 Next.js runtime and removed Ecosystem: Frameworks labels Mar 13, 2024
@MarcL
Copy link
Contributor

MarcL commented Apr 18, 2024

We've now got a solid test suite for the v5 runtime so closing this as we don't plan to do the same for v4.

@MarcL MarcL closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: low reliability code to address reliability issues type: chore work needed to keep the product and development running smoothly v4 Issues related to the v4 Next.js runtime
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@nickytonline @MarcL @orinokai @tiffafoo