chore: vendor deno modules used in integration test helpers #2883
+98
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
mrstork
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Seems like added test in #2862 introduces flakiness when setup up fixture in integration tests. I don't think the test itself is the cause of it, but rather the fact that Vitest run few parallel workers all trying to bundle edge functions at the same time and to do that Deno does download eszip wasm file to same cache location in multiple processes around the same time sometimes causing corruption (and added test is just unfortunate to be likely to hit this problem). This adds a step in CI to vendor modules and wasm files used by eszip helper we use to handle edge functions in integration tests which seems to avoid the problem in my tests ( https://github.com/opennextjs/opennextjs-netlify/actions/runs/14751501851?pr=2882 - do note that there are some failing tests there, but those seems like they are caused by something in newest next.js canary and are not related to this change).
This moves deno modules vendoring we already have for package build into helper module which is used by both package build as well as being used for eszip helper in CI
Documentation
Tests
You can test this change yourself like so:
Relevant links (GitHub issues, etc.) or a picture of cute animal