Revert "Eventdispatcherissue (#35) (#54)"

kellyroach-optimizely · kellyroach-optimizely · commit bdaa7be155e1 · 2018-03-29T14:37:08.000-07:00
This reverts commit 5df7cfb.
diff --git a/OptimizelySDK/Event/Dispatcher/HttpClientEventDispatcher45.cs b/OptimizelySDK/Event/Dispatcher/HttpClientEventDispatcher45.cs
@@ -41,7 +41,7 @@ static HttpClientEventDispatcher45()
         /// <summary>
         /// Dispatch an Event asynchronously
         /// </summary>
-        private async Task DispatchEventAsync(LogEvent logEvent)
+        private async void DispatchEventAsync(LogEvent logEvent)
         {
             try
             {
@@ -68,11 +68,13 @@ private async Task DispatchEventAsync(LogEvent logEvent)
         }
 
         /// <summary>
-        /// Dispatch an event
+        /// Dispatch an event Asynchronously by creating a new task and calls the 
+        /// Async version of DispatchEvent
+        /// This is a "Fire and Forget" option
         /// </summary>
         public void DispatchEvent(LogEvent logEvent)
         {
-            Task.Run(() => DispatchEventAsync(logEvent)).Wait();            
+            Task.Run(() => DispatchEventAsync(logEvent));
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ static HttpClientEventDispatcher45()`
`41`	`41`	`/// <summary>`
`42`	`42`	`/// Dispatch an Event asynchronously`
`43`	`43`	`/// </summary>`
`44`		`- private async Task DispatchEventAsync(LogEvent logEvent)`
	`44`	`+ private async void DispatchEventAsync(LogEvent logEvent)`
`45`	`45`	`{`
`46`	`46`	`try`
`47`	`47`	`{`
`@@ -68,11 +68,13 @@ private async Task DispatchEventAsync(LogEvent logEvent)`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`/// <summary>`
`71`		`- /// Dispatch an event`
	`71`	`+ /// Dispatch an event Asynchronously by creating a new task and calls the`
	`72`	`+ /// Async version of DispatchEvent`
	`73`	`+ /// This is a "Fire and Forget" option`
`72`	`74`	`/// </summary>`
`73`	`75`	`public void DispatchEvent(LogEvent logEvent)`
`74`	`76`	`{`
`75`		`- Task.Run(() => DispatchEventAsync(logEvent)).Wait();`
	`77`	`+ Task.Run(() => DispatchEventAsync(logEvent));`
`76`	`78`	`}`
`77`	`79`	`}`
`78`	`80`	`}`