Skip to content

chore: preparing 3.10.0 release. #283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 16, 2021
Merged

chore: preparing 3.10.0 release. #283

merged 3 commits into from
Sep 16, 2021

Conversation

msohailhussain
Copy link
Contributor

Summary

  • prepare for release 3.9.0

@msohailhussain msohailhussain requested a review from a team as a code owner September 16, 2021 05:00
@msohailhussain msohailhussain removed their assignment Sep 16, 2021
dustin-sier
dustin-sier approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@dustin-sier dustin-sier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@The-inside-man
Copy link

Should we include deprecation notes in the release notes ?

@msohailhussain
Copy link
Contributor Author

Should we include deprecation notes in the release notes ?

In the developer doc we have already mentioned there.

jaeopt
jaeopt requested changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some OptimizelyConfig, etc has backticks and others not. Can be consistent.

jaeopt
jaeopt approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@jaeopt jaeopt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@msohailhussain msohailhussain merged commit 803bc57 into master Sep 16, 2021
@msohailhussain msohailhussain deleted the prep-3.10.0 branch September 16, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeopt jaeopt jaeopt approved these changes

@dustin-sier dustin-sier dustin-sier approved these changes

Assignees

@msohailhussain msohailhussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@msohailhussain @The-inside-man @jaeopt @dustin-sier