Skip to content

maint: apply code formatting rules to pass CI linter #327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 15, 2023
Merged

maint: apply code formatting rules to pass CI linter #327

merged 7 commits into from
Feb 15, 2023

Conversation

mikechu-optimizely
Copy link
Contributor

Summary

  • Create/update ruleset in .editorconfig that is industry accepted AND approved by C# devs
  • Apply the code quality / formatting ruleset to 
    • OptimizelySDK
    • OptimizelySDK.Tests
  • Adjust GitHub workflow yml to lint the whole codebase and not just the modified files 

Test plan

  • Confirm unit tests report successful results
  • Confirm super-linter runs in GitHub Actions and confirm whole SDK adheres to the established ruleset

Issues

  • FSSDK-8844

@mikechu-optimizely mikechu-optimizely changed the title feat: apply code formatting rules to pass CI linter maint: apply code formatting rules to pass CI linter Feb 14, 2023
@mikechu-optimizely mikechu-optimizely marked this pull request as ready for review February 14, 2023 16:25
@mikechu-optimizely mikechu-optimizely requested a review from a team as a code owner February 14, 2023 16:25
msohailhussain
msohailhussain approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikechu-optimizely
Copy link
Contributor Author

lgtm

Seriously @msohailhussain ? 😮 DM me if you want.

It looks like FSC isnt' happy anyway.

@mikechu-optimizely mikechu-optimizely merged commit a4c5b57 into master Feb 15, 2023
@mikechu-optimizely mikechu-optimizely deleted the mike/full-repo-linting branch February 15, 2023 19:39
mnoman09 pushed a commit that referenced this pull request Mar 10, 2023
@NomanShoaib
maint: apply code formatting rules to pass CI linter (#327)
49466b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msohailhussain msohailhussain msohailhussain approved these changes

@mnoman09 mnoman09 Awaiting requested review from mnoman09

Assignees

@mikechu-optimizely mikechu-optimizely

Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikechu-optimizely @msohailhussain