Skip to content

[FSSDK-8938] chore: Updated newtonsoft.Json version and NjsonSchema version #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 27, 2023

Conversation

mnoman09
Copy link
Contributor

@mnoman09 mnoman09 commented Feb 21, 2023

Summary

  • Upgraded Newtonsoft.Json to 13.0.2
  • Upgraded NJsonSchema to 10.8.0.

Test plan

All tests should pass.

Issues

@mnoman09 mnoman09 marked this pull request as ready for review February 22, 2023 14:52
@mnoman09 mnoman09 requested a review from a team as a code owner February 22, 2023 14:52
@mnoman09 mnoman09 removed their assignment Feb 22, 2023
Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

<Reference Include="System.Xml.Linq" />
<Reference Include="System.Data.DataSetExtensions" />
<Reference Include="System.Data" />
<Reference Include="System.Xml" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why so many references are added.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were added automatically when I updated the package. Additional dependency of Namotion.Reflection was added automatically and it is now a required dependency.

Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update nuspec as well to use v3.

@mikechu-optimizely
Copy link
Contributor

Please update nuspec as well to use v3.

Great catch. I did not know about .nuspec reqs. Still much to learn. Thanks Sohail & Noman

@mnoman09 mnoman09 removed their assignment Feb 27, 2023
@mnoman09 mnoman09 changed the title chore: Updated newtonsoft.Json version and NjsonSchema version [FSSDK-8938] chore: Updated newtonsoft.Json version and NjsonSchema version Feb 27, 2023
Copy link
Contributor

@msohailhussain msohailhussain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikechu-optimizely mikechu-optimizely merged commit 503c7d8 into master Feb 27, 2023
@mikechu-optimizely mikechu-optimizely deleted the mnoman/FSSDK-8938 branch February 27, 2023 19:23
@nuttytree
Copy link

@mikechu-optimizely when do you think this will get released?

@mikechu-optimizely
Copy link
Contributor

@nuttytree, We have a major new feature releasing soon which will of course include this edit to NuGet.

Let me put an agenda item on today's stand up meeting to discuss.

cc @russell-loube-optimizely

mikechu-optimizely pushed a commit that referenced this pull request Mar 15, 2023
…ersion (#330)

* Updated newtonsoft.Json version and NjsonSchema version

* fix

* reverting endline

* updated to latest

* Updated version in nuspec

* Reverting unneseccary dependency

* Namotion.reflection is required dependency after update

---------

Co-authored-by: mnoman09 <m.nomanshoaib09@gmail.com>
Co-authored-by: Mike Chu <104384559+mikechu-optimizely@users.noreply.github.com>

(cherry picked from commit 503c7d8)
mnoman09 added a commit that referenced this pull request Mar 16, 2023
* chore : updated prefix of ticket-check action (#314)

(cherry picked from commit 678c6fd)

* chore: Fix and Reconfigure GitHub Actions (#319)

* Fix <return> method doc for IsFeatureEnabled (#329)

* [FSSDK-8938] chore: Updated newtonsoft.Json version and NjsonSchema version (#330)

* [FSSDK-8955] Refac: Replaced all instances of full stack except from changelog file and code files (#331)

* Replaced all instances of full stack except from changelog file and code files

Co-authored-by: Griffin Cox <104227910+griffincox-optimizely@users.noreply.github.com>

* [FSSDK-8955] Do not lint markdown for now

* [FSSDK-8955] Remove VALIDATE_MARKDOWN

---------

Co-authored-by: mnoman09 <m.nomanshoaib09@gmail.com>
Co-authored-by: Griffin Cox <104227910+griffincox-optimizely@users.noreply.github.com>
Co-authored-by: Mike Chu <michael.chu@optimizely.com>
(cherry picked from commit 5f16357)
(cherry picked from commit 887166e)

* [FSSDK-8955] Refac: Replaced all instances of full stack  from code comments and in nuspec except owner. (#332)

(cherry picked from commit 2a5b19c)

* [FSSDK-8955] chore: prepare for release 3.11.2 (#333)

* [FSSDK-8955] chore: prepare for release 3.11.2

* Nit fixed

---------

Co-authored-by: mnoman09 <m.nomanshoaib09@gmail.com>
(cherry picked from commit e620c08)

* updated release date to 16th March

---------

Co-authored-by: Muhammad Shaharyar <shairy333@gmail.com>
Co-authored-by: Mike Chu <104384559+mikechu-optimizely@users.noreply.github.com>
Co-authored-by: mnoman09 <m.nomanshoaib09@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants