Skip to content

Feature/notification listeners #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Dec 20, 2017

Conversation

thomaszurkan-optimizely
Copy link
Contributor

No description provided.

@wangjoshuah
Copy link
Contributor

build

Copy link
Contributor

@wangjoshuah wangjoshuah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thomaszurkan-optimizely thomaszurkan-optimizely merged commit 429ad63 into master Dec 20, 2017
thomaszurkan-optimizely added a commit that referenced this pull request Jan 30, 2018
* notification center

* update tests and notifications

* test for all callback values

* fix some typos and add logging along with try/catch for sendNotifications.

* adding another listener unit test

* finish unit tests

* tweak notificaion type, add javadocs and comments

* added more tests and fix typo

* refactor notification listener

* update from notification to notificationListener where appropriate
@aliabbasrizvi aliabbasrizvi deleted the feature/notificationListeners branch February 5, 2018 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants