Skip to content

chore(test): Delete unused karma.conf.js #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 29, 2018

Conversation

spencerwilson-optimizely
Copy link
Contributor

@spencerwilson-optimizely spencerwilson-optimizely commented Jun 28, 2018

Summary

  • Delete unused Karma conf file.

We seem to only use karma.bs.conf.js.

Test plan

CI.

@spencerwilson-optimizely spencerwilson-optimizely changed the title fix(test): Delete unused karma.conf.js chore(test): Delete unused karma.conf.js Jun 28, 2018
@mikeproeng37
Copy link
Contributor

I think this is Auto generated when you run the browser tests locally. We could probably add it to .gitignore as well. Anyway, not gonna block the merge =)

@coveralls
Copy link

coveralls commented Jun 29, 2018

Coverage Status

Coverage remained the same at 97.11% when pulling 50733ce on sw/delete-unused-karma-conf into 9d5d8ef on master.

@spencerwilson-optimizely spencerwilson-optimizely merged commit 05ec7d9 into master Jun 29, 2018
@spencerwilson-optimizely spencerwilson-optimizely deleted the sw/delete-unused-karma-conf branch June 29, 2018 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants