Skip to content

[OASIS-3799] Tests for automatically created logger instances #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 3, 2018
Merged

[OASIS-3799] Tests for automatically created logger instances #197

merged 1 commit into from
Dec 3, 2018

Conversation

caitlinrubin-optimizely
Copy link
Contributor

Summary

  • Ported over the last two tests from xbrowser to umd for 'automatically created logger instances' -- these tests are different because they rely on console output, which is inaccessible from the umd bundle optly. Testing that indirectly here by spying on console.log and console.error

Test plan

  • Ran the tests

Issues

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.239% when pulling 392b3c7 on crubin/umd_default_logger_tests into 09075ed on master.

mikeproeng37
mikeproeng37 approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mikeproeng37 mikeproeng37 merged commit 9d249a2 into master Dec 3, 2018
@mikeproeng37 mikeproeng37 deleted the crubin/umd_default_logger_tests branch January 14, 2019 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@mjc1283 mjc1283 Awaiting requested review from mjc1283

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caitlinrubin-optimizely @coveralls @mikeproeng37