feat(Audience Evaluation): Use log messages to explain the outcome of audience evaluation #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nchilada
suggested changes
Feb 4, 2019
packages/optimizely-sdk/lib/core/custom_attribute_condition_evaluator/index.js
Outdated
Show resolved
Hide resolved
packages/optimizely-sdk/lib/core/custom_attribute_condition_evaluator/index.js
Outdated
Show resolved
Hide resolved
packages/optimizely-sdk/lib/core/custom_attribute_condition_evaluator/index.js
Outdated
Show resolved
Hide resolved
packages/optimizely-sdk/lib/core/decision_service/index.tests.js
Outdated
Show resolved
Hide resolved
nchilada
suggested changes
Feb 6, 2019
| var result = conditionTreeEvaluator.evaluate(audience.conditions, evaluateConditionWithUserAttributes); | ||
| var resultText = result === null ? 'UNKNOWN' : sprintf('%s', result); | ||
| logger.log(LOG_LEVEL.DEBUG, sprintf(LOG_MESSAGES.AUDIENCE_EVALUATION_RESULT, MODULE_NAME, audienceId, resultText)); | ||
| var resultText = result === null ? 'UNKNOWN' : result.toString().toUpperCase(); |
There was a problem hiding this comment.
result.toString() only works if result isn't null or undefined, but I guess we should be okay in this case. 👍
packages/optimizely-sdk/lib/core/audience_evaluator/index.tests.js
Outdated
Show resolved
Hide resolved
packages/optimizely-sdk/lib/core/custom_attribute_condition_evaluator/index.js
Show resolved
Hide resolved
| } | ||
|
|
||
| if (!fns.isFinite(userValue)) { | ||
| logger.log(LOG_LEVEL.WARNING, sprintf(LOG_MESSAGES.UNEXPECTED_TYPE, MODULE_NAME, JSON.stringify(condition), conditionName, userValue)); |
There was a problem hiding this comment.
Thanks for changing this! Looks like you also fixed the order of the last two arguments. I'm guessing the test case¹ was failing and we just hadn't noticed yet?
¹ should log and return null if the user-provided value is of a different type than the condition value
nchilada
suggested changes
Feb 7, 2019
packages/optimizely-sdk/lib/core/custom_attribute_condition_evaluator/index.js
Outdated
Show resolved
Hide resolved
packages/optimizely-sdk/lib/core/custom_attribute_condition_evaluator/index.js
Outdated
Show resolved
Hide resolved
packages/optimizely-sdk/lib/core/custom_attribute_condition_evaluator/index.js
Outdated
Show resolved
Hide resolved
packages/optimizely-sdk/lib/core/custom_attribute_condition_evaluator/index.js
Outdated
Show resolved
Hide resolved
packages/optimizely-sdk/lib/core/custom_attribute_condition_evaluator/index.tests.js
Show resolved
Hide resolved
nchilada
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds logging for audience evaluation.