From 20b89f53d97b4c6f79642dad522687f365cc171e Mon Sep 17 00:00:00 2001 From: Brandon Date: Tue, 6 Aug 2019 10:54:51 -0700 Subject: [PATCH 1/4] update changelog to include getFV method --- packages/optimizely-sdk/CHANGELOG.MD | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/optimizely-sdk/CHANGELOG.MD b/packages/optimizely-sdk/CHANGELOG.MD index 8e6691c5b..adbc796c0 100644 --- a/packages/optimizely-sdk/CHANGELOG.MD +++ b/packages/optimizely-sdk/CHANGELOG.MD @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ## [Unreleased] Changes that have landed but are not yet released. +- Added non-typed `getFeatureVariable` method ([#298](https://github.com/optimizely/javascript-sdk/pull/298)) as a more idiomatic approach to getting values of feature variables. + - Typed `getFeatureVariable` methods will still be available for use. + ### New Features - Updated the `close` method to return a `Promise` representing the process of closing the instance. When `close` is called, any events waiting to be sent as part of a batched event request will be immediately batched and sent to the event dispatcher. - If any such requests were sent to the event dispatcher, `close` returns a `Promise` that fulfills after the event dispatcher calls the response callback for each request. Otherwise, `close` returns an immediately-fulfilled `Promise`. From c7107799e39c4f3f545effa9f4acb6ac9500a333 Mon Sep 17 00:00:00 2001 From: Brandon Date: Tue, 6 Aug 2019 10:54:51 -0700 Subject: [PATCH 2/4] update changelog to include getFV method --- packages/optimizely-sdk/CHANGELOG.MD | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/optimizely-sdk/CHANGELOG.MD b/packages/optimizely-sdk/CHANGELOG.MD index 8e6691c5b..adbc796c0 100644 --- a/packages/optimizely-sdk/CHANGELOG.MD +++ b/packages/optimizely-sdk/CHANGELOG.MD @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ## [Unreleased] Changes that have landed but are not yet released. +- Added non-typed `getFeatureVariable` method ([#298](https://github.com/optimizely/javascript-sdk/pull/298)) as a more idiomatic approach to getting values of feature variables. + - Typed `getFeatureVariable` methods will still be available for use. + ### New Features - Updated the `close` method to return a `Promise` representing the process of closing the instance. When `close` is called, any events waiting to be sent as part of a batched event request will be immediately batched and sent to the event dispatcher. - If any such requests were sent to the event dispatcher, `close` returns a `Promise` that fulfills after the event dispatcher calls the response callback for each request. Otherwise, `close` returns an immediately-fulfilled `Promise`. From 5a29701a71130f6c9c271ef57d969a1a4222dc39 Mon Sep 17 00:00:00 2001 From: Brandon Date: Tue, 6 Aug 2019 11:25:55 -0700 Subject: [PATCH 3/4] place getFeatureVariable under New Features --- packages/optimizely-sdk/CHANGELOG.MD | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/optimizely-sdk/CHANGELOG.MD b/packages/optimizely-sdk/CHANGELOG.MD index adbc796c0..fb822dcd1 100644 --- a/packages/optimizely-sdk/CHANGELOG.MD +++ b/packages/optimizely-sdk/CHANGELOG.MD @@ -7,13 +7,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ## [Unreleased] Changes that have landed but are not yet released. -- Added non-typed `getFeatureVariable` method ([#298](https://github.com/optimizely/javascript-sdk/pull/298)) as a more idiomatic approach to getting values of feature variables. - - Typed `getFeatureVariable` methods will still be available for use. - ### New Features - Updated the `close` method to return a `Promise` representing the process of closing the instance. When `close` is called, any events waiting to be sent as part of a batched event request will be immediately batched and sent to the event dispatcher. - If any such requests were sent to the event dispatcher, `close` returns a `Promise` that fulfills after the event dispatcher calls the response callback for each request. Otherwise, `close` returns an immediately-fulfilled `Promise`. - The `Promise` returned from `close` is fulfilled with a result object containing `success` (boolean) and `reason` (string, only when success is `false`) properties. In the result object, `success` is `true` if all events in the queue at the time close was called were combined into requests, sent to the event dispatcher, and the event dispatcher called the callbacks for each request. `success` is false if an unexpected error was encountered during the close process. +- Added non-typed `getFeatureVariable` method ([#298](https://github.com/optimizely/javascript-sdk/pull/298)) as a more idiomatic approach to getting values of feature variables. + - Typed `getFeatureVariable` methods will still be available for use. ## [3.2.1] - July 1st, 2019 From 2a2cfec8c5c0fadd521ff36df0e5d75a24fc4ea3 Mon Sep 17 00:00:00 2001 From: Brandon Date: Tue, 6 Aug 2019 11:28:34 -0700 Subject: [PATCH 4/4] remove getFeatureVariable above New Features --- packages/optimizely-sdk/CHANGELOG.MD | 3 --- 1 file changed, 3 deletions(-) diff --git a/packages/optimizely-sdk/CHANGELOG.MD b/packages/optimizely-sdk/CHANGELOG.MD index ec26f089a..fb822dcd1 100644 --- a/packages/optimizely-sdk/CHANGELOG.MD +++ b/packages/optimizely-sdk/CHANGELOG.MD @@ -7,9 +7,6 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. ## [Unreleased] Changes that have landed but are not yet released. -- Added non-typed `getFeatureVariable` method ([#298](https://github.com/optimizely/javascript-sdk/pull/298)) as a more idiomatic approach to getting values of feature variables. - - Typed `getFeatureVariable` methods will still be available for use. - ### New Features - Updated the `close` method to return a `Promise` representing the process of closing the instance. When `close` is called, any events waiting to be sent as part of a batched event request will be immediately batched and sent to the event dispatcher. - If any such requests were sent to the event dispatcher, `close` returns a `Promise` that fulfills after the event dispatcher calls the response callback for each request. Otherwise, `close` returns an immediately-fulfilled `Promise`.