Skip to content

[FSSDK-9586] restore node engine to >=14 #912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 7, 2024
Merged

[FSSDK-9586] restore node engine to >=14 #912

merged 2 commits into from
Mar 7, 2024

Conversation

raju-opti
Copy link
Contributor

also add back unit test ci for node14

v5.0.0 was released with engine.node >=14.0.0. So updating this technically constitutes a breaking change.

Test plan

Issues

  • FSSDK-9586

also add back unit test ci for node14
@coveralls
Copy link

Coverage Status

coverage: 90.373%. remained the same
when pulling 2f1cfcd on raju/node14
into 0788f85 on master.

Copy link
Contributor

@mikechu-optimizely mikechu-optimizely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@raju-opti raju-opti merged commit a1658d0 into master Mar 7, 2024
@raju-opti raju-opti deleted the raju/node14 branch March 7, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants