updating log message

aliabbasrizvi · aliabbasrizvi · commit 07b86929bfdd · 2017-08-29T10:15:37.000+05:30
diff --git a/optimizely/decision_service.py b/optimizely/decision_service.py
@@ -190,13 +190,17 @@ def get_variation_for_rollout(self, rollout, user_id, attributes=None, ignore_us
           return variation
         else:
           # Evaluate no further rules
+          self.logger.log(enums.LogLevels.DEBUG,
+                          'User "%s" is not in the traffic group for the targeting else. '
+                          'Checking "Everyone Else" rule now.' % user_id)
           break
 
-      # Evaluate last rule
+      # Evaluate last rule i.e. "Everyone Else" rule
+      everyone_else_experiment = rollout.experiments[-1]
       if audience_helper.is_user_in_experiment(self.config,
                                                self.config.get_experiment_from_key(rollout.experiments[-1].get('key')),
                                                attributes):
-        variation = self.bucketer.bucket(rollout.experiments[-1], user_id)
+        variation = self.bucketer.bucket(everyone_else_experiment, user_id)
         if variation:
           self.logger.log(enums.LogLevels.DEBUG,
                           'User "%s" meets conditions for targeting rule "Everyone Else".' % user_id)
diff --git a/tests/test_decision_service.py b/tests/test_decision_service.py
@@ -331,6 +331,7 @@ def test_get_variation__ignore_user_profile_when_specified(self):
 
   def test_get_variation_for_feature__returns_variation_for_feature_in_experiment(self):
     """ Test that get_variation_for_feature returns the variation of the experiment the feature is associated with. """
+
     opt_obj = optimizely.Optimizely(json.dumps(self.config_dict_with_features))
     project_config = opt_obj.config
     decision_service = opt_obj.decision_service
@@ -349,6 +350,7 @@ def test_get_variation_for_feature__returns_variation_for_feature_in_experiment(
   def test_get_variation_for_feature__returns_variation_for_feature_in_rollout(self):
     """ Test that get_variation_for_feature returns the variation of
     the experiment in the rollout that the user is bucketed into. """
+
     opt_obj = optimizely.Optimizely(json.dumps(self.config_dict_with_features))
     project_config = opt_obj.config
     decision_service = opt_obj.decision_service
@@ -364,6 +366,7 @@ def test_get_variation_for_feature__returns_variation_for_feature_in_rollout(sel
   def test_get_variation_for_feature__returns_variation_if_user_not_in_experiment_but_in_rollout(self):
     """ Test that get_variation_for_feature returns the variation of the experiment in the
     feature's rollout even if the user is not bucketed into the feature's experiment. """
+
     opt_obj = optimizely.Optimizely(json.dumps(self.config_dict_with_features))
     project_config = opt_obj.config
     decision_service = opt_obj.decision_service
@@ -383,6 +386,7 @@ def test_get_variation_for_feature__returns_variation_if_user_not_in_experiment_
   def test_get_variation_for_feature__returns_variation_for_feature_in_group(self):
     """ Test that get_variation_for_feature returns the variation of
      the experiment the user is bucketed in the feature's group. """
+
     opt_obj = optimizely.Optimizely(json.dumps(self.config_dict_with_features))
     project_config = opt_obj.config
     decision_service = opt_obj.decision_service
@@ -402,6 +406,7 @@ def test_get_variation_for_feature__returns_variation_for_feature_in_group(self)
   def test_get_variation_for_feature__returns_none_for_user_not_in_group(self):
     """ Test that get_variation_for_feature returns None for
     user not in group and the feature is not part of a rollout. """
+
     opt_obj = optimizely.Optimizely(json.dumps(self.config_dict_with_features))
     project_config = opt_obj.config
     decision_service = opt_obj.decision_service
@@ -418,6 +423,7 @@ def test_get_variation_for_feature__returns_none_for_user_not_in_group(self):
 
   def test_get_variation_for_feature__returns_none_for_user_not_in_experiment(self):
     """ Test that get_variation_for_feature returns None for user not in the associated experiment. """
+
     opt_obj = optimizely.Optimizely(json.dumps(self.config_dict_with_features))
     project_config = opt_obj.config
     decision_service = opt_obj.decision_service
@@ -434,6 +440,7 @@ def test_get_variation_for_feature__returns_none_for_user_not_in_experiment(self
 
   def test_get_variation_for_feature__returns_none_for_user_not_in_rollout(self):
     """ Test that get_variation_for_feature returns None for the user not in the associated rollout. """
+
     opt_obj = optimizely.Optimizely(json.dumps(self.config_dict_with_features))
     project_config = opt_obj.config
     decision_service = opt_obj.decision_service
@@ -451,6 +458,7 @@ def test_get_variation_for_feature__returns_none_for_user_not_in_rollout(self):
   def test_get_variation_for_feature__returns_none_for_user_in_group_but_experiment_not_associated_with_feature(self):
     """ Test that if a user is in the mutex group but the experiment is
     not targeting a feature, then None is returned. """
+
     opt_obj = optimizely.Optimizely(json.dumps(self.config_dict_with_features))
     project_config = opt_obj.config
     decision_service = opt_obj.decision_service
