From 2c5b794d88406c0115e75edfb4e15cf09daef2fc Mon Sep 17 00:00:00 2001 From: Jacob Brown Date: Thu, 16 Sep 2021 12:07:53 -0400 Subject: [PATCH 1/3] Deprecate OptimizelyFeature experiments map and OptimizelyConfig experiments_map. --- optimizely/optimizely_config.py | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/optimizely/optimizely_config.py b/optimizely/optimizely_config.py index 4dc90bdc..351d331a 100644 --- a/optimizely/optimizely_config.py +++ b/optimizely/optimizely_config.py @@ -22,7 +22,13 @@ def __init__(self, revision, experiments_map, features_map, datafile=None, sdk_key=None, environment_key=None, attributes=None, events=None, audiences=None): self.revision = revision + + # This experimentsMap is for experiments of legacy projects only. + # For flag projects, experiment keys are not guaranteed to be unique + # across multiple flags, so this map may not include all experiments + # when keys conflict. self.experiments_map = experiments_map + self.features_map = features_map self._datafile = datafile self.sdk_key = sdk_key or '' @@ -52,7 +58,11 @@ class OptimizelyFeature(object): def __init__(self, id, key, experiments_map, variables_map): self.id = id self.key = key + + # This experiments_map is now deprecated, + # Please use delivery_rules and experiment_rules self.experiments_map = experiments_map + self.variables_map = variables_map self.delivery_rules = [] self.experiment_rules = [] From 33589d791182381b02a581528fb5bfa295187def Mon Sep 17 00:00:00 2001 From: Jacob Brown Date: Thu, 16 Sep 2021 12:13:37 -0400 Subject: [PATCH 2/3] remove white space --- optimizely/optimizely_config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/optimizely/optimizely_config.py b/optimizely/optimizely_config.py index 351d331a..fc63edcd 100644 --- a/optimizely/optimizely_config.py +++ b/optimizely/optimizely_config.py @@ -62,7 +62,7 @@ def __init__(self, id, key, experiments_map, variables_map): # This experiments_map is now deprecated, # Please use delivery_rules and experiment_rules self.experiments_map = experiments_map - + self.variables_map = variables_map self.delivery_rules = [] self.experiment_rules = [] From 3f0f9f1b13939ae38b6d01000f3cc54c25e479b3 Mon Sep 17 00:00:00 2001 From: Jacob Brown Date: Thu, 16 Sep 2021 12:30:51 -0400 Subject: [PATCH 3/3] update xomment to reflect experiments_map instead of camelcaps. --- optimizely/optimizely_config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/optimizely/optimizely_config.py b/optimizely/optimizely_config.py index fc63edcd..5e9b58d2 100644 --- a/optimizely/optimizely_config.py +++ b/optimizely/optimizely_config.py @@ -23,7 +23,7 @@ def __init__(self, revision, experiments_map, features_map, datafile=None, audiences=None): self.revision = revision - # This experimentsMap is for experiments of legacy projects only. + # This experiments_map is for experiments of legacy projects only. # For flag projects, experiment keys are not guaranteed to be unique # across multiple flags, so this map may not include all experiments # when keys conflict.