From 9a7f7f02f686b2011a7748a5312409128c980981 Mon Sep 17 00:00:00 2001 From: FarhanAnjum-opti Date: Wed, 11 Dec 2024 23:37:02 +0600 Subject: [PATCH] All threads have been named --- .gitignore | 2 ++ optimizely/config_manager.py | 2 +- optimizely/event/event_processor.py | 3 +-- optimizely/odp/odp_event_manager.py | 2 +- optimizely/optimizely_user_context.py | 2 +- 5 files changed, 6 insertions(+), 5 deletions(-) diff --git a/.gitignore b/.gitignore index cff402c4c..00ad86a4f 100644 --- a/.gitignore +++ b/.gitignore @@ -3,6 +3,7 @@ MANIFEST .idea/* .*virtualenv/* .mypy_cache +.vscode/* # Output of building package *.egg-info @@ -26,3 +27,4 @@ datafile.json # Sphinx documentation docs/build/ + diff --git a/optimizely/config_manager.py b/optimizely/config_manager.py index 755c6b9cd..c959914ed 100644 --- a/optimizely/config_manager.py +++ b/optimizely/config_manager.py @@ -432,7 +432,7 @@ def start(self) -> None: self._polling_thread.start() def _initialize_thread(self) -> None: - self._polling_thread = threading.Thread(target=self._run, daemon=True) + self._polling_thread = threading.Thread(target=self._run, name="PollThread", daemon=True) class AuthDatafilePollingConfigManager(PollingConfigManager): diff --git a/optimizely/event/event_processor.py b/optimizely/event/event_processor.py index 9445ffc64..05f5e078b 100644 --- a/optimizely/event/event_processor.py +++ b/optimizely/event/event_processor.py @@ -186,8 +186,7 @@ def start(self) -> None: return self.flushing_interval_deadline = self._get_time() + self._get_time(self.flush_interval.total_seconds()) - self.executor = threading.Thread(target=self._run) - self.executor.daemon = True + self.executor = threading.Thread(target=self._run, name="EventThread", daemon=True) self.executor.start() def _run(self) -> None: diff --git a/optimizely/odp/odp_event_manager.py b/optimizely/odp/odp_event_manager.py index 18b08eb01..85512e909 100644 --- a/optimizely/odp/odp_event_manager.py +++ b/optimizely/odp/odp_event_manager.py @@ -75,7 +75,7 @@ def __init__( self.retry_count = OdpEventManagerConfig.DEFAULT_RETRY_COUNT self._current_batch: list[OdpEvent] = [] """_current_batch should only be modified by the processing thread, as it is not thread safe""" - self.thread = Thread(target=self._run, daemon=True) + self.thread = Thread(target=self._run, name="OdpThread", daemon=True) self.thread_exception = False """thread_exception will be True if the processing thread did not exit cleanly""" diff --git a/optimizely/optimizely_user_context.py b/optimizely/optimizely_user_context.py index fb674f93f..e88c0f521 100644 --- a/optimizely/optimizely_user_context.py +++ b/optimizely/optimizely_user_context.py @@ -336,7 +336,7 @@ def _fetch_qualified_segments() -> bool: return success if callback: - fetch_thread = threading.Thread(target=_fetch_qualified_segments) + fetch_thread = threading.Thread(target=_fetch_qualified_segments, name="FetchQualifiedSegmentsThread") fetch_thread.start() return fetch_thread else: