Skip to content

Updating mmh3 for Python to handle Windows 10 installation issues #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2017
Merged

Updating mmh3 for Python to handle Windows 10 installation issues #93

merged 1 commit into from
Dec 18, 2017

Conversation

aliabbasrizvi
Copy link
Contributor

@optimizely/fullstack-devs

mikeproeng37
mikeproeng37 approved these changes Dec 18, 2017
View reviewed changes
Copy link
Contributor

@mikeproeng37 mikeproeng37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please hold off until e2e tests pass

wangjoshuah
wangjoshuah approved these changes Dec 18, 2017
View reviewed changes
Copy link
Contributor

@wangjoshuah wangjoshuah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same: just wait for tests.

@coveralls
Copy link

coveralls commented Dec 18, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 97.048% when pulling e5c9e15 on arizvi/update_mmh3 into eb3d971 on master.

@aliabbasrizvi aliabbasrizvi merged commit 3d7e85f into master Dec 18, 2017
@aliabbasrizvi aliabbasrizvi deleted the arizvi/update_mmh3 branch December 18, 2017 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeproeng37 mikeproeng37 mikeproeng37 approved these changes

@wangjoshuah wangjoshuah wangjoshuah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aliabbasrizvi @coveralls @mikeproeng37 @wangjoshuah