Fix memory leak on error path in cxoObjectType_initialize (#422)

alexhenrie · web-flow · commit 528dec685926 · 2020-04-18T21:38:31.000-06:00
Signed-off-by: Alex Henrie &lt;alexhenrie24@gmail.com&gt;
diff --git a/src/cxoObjectType.c b/src/cxoObjectType.c
@@ -146,8 +146,10 @@ static int cxoObjectType_initialize(cxoObjectType *objType,
         }
         PyList_SET_ITEM(objType->attributes, i, (PyObject*) attr);
         if (PyDict_SetItem(objType->attributesByName, attr->name,
-                (PyObject*) attr) < 0)
+                (PyObject*) attr) < 0) {
+            PyMem_Free(attributes);
             return -1;
+        }
     }
     PyMem_Free(attributes);
     return 0;

Original file line number	Diff line number	Diff line change
`@@ -146,8 +146,10 @@ static int cxoObjectType_initialize(cxoObjectType *objType,`
`146`	`146`	`}`
`147`	`147`	`PyList_SET_ITEM(objType->attributes, i, (PyObject*) attr);`
`148`	`148`	`if (PyDict_SetItem(objType->attributesByName, attr->name,`
`149`		`- (PyObject*) attr) < 0)`
	`149`	`+ (PyObject*) attr) < 0) {`
	`150`	`+ PyMem_Free(attributes);`
`150`	`151`	`return -1;`
	`152`	`+ }`
`151`	`153`	`}`
`152`	`154`	`PyMem_Free(attributes);`
`153`	`155`	`return 0;`