Correct support for booleans in data frames.

anthony-tuininga · anthony-tuininga · commit 1920c4220f56 · 2025-03-28T20:08:47.000-06:00
diff --git a/doc/src/release_notes.rst b/doc/src/release_notes.rst
@@ -61,6 +61,7 @@ Common Changes
     and :meth:`Connection.fetch_df_batches()`:
 
     - Added support for CLOB, BLOB and RAW data types
+    - Fixed support for BOOLEAN data type
     - Fixed bug when NUMBER data is fetched that does not have a precision or
       scale specified and :attr:`defaults.fetch_decimals` is set to *True*.
     - More efficient processing when a significant amount of data is duplicated
diff --git a/src/oracledb/impl/base/converters.pyx b/src/oracledb/impl/base/converters.pyx
@@ -232,6 +232,8 @@ cdef int convert_oracle_data_to_arrow(OracleMetadata from_metadata,
             arrow_array.append_double(data.buffer.as_double)
     elif arrow_type == NANOARROW_TYPE_FLOAT:
         arrow_array.append_float(data.buffer.as_float)
+    elif arrow_type == NANOARROW_TYPE_BOOL:
+        arrow_array.append_int64(data.buffer.as_bool)
     elif arrow_type in (
             NANOARROW_TYPE_BINARY,
             NANOARROW_TYPE_STRING,
diff --git a/src/oracledb/interchange/nanoarrow_bridge.pyx b/src/oracledb/interchange/nanoarrow_bridge.pyx
@@ -89,6 +89,7 @@ cdef extern from "nanoarrow/nanoarrow.c":
     ArrowErrorCode ArrowArrayViewSetArray(ArrowArrayView* array_view,
                                           const ArrowArray* array,
                                           ArrowError* error)
+    int8_t ArrowBitGet(const uint8_t* bits, int64_t i)
     void ArrowSchemaInit(ArrowSchema* schema)
     ArrowErrorCode ArrowSchemaInitFromType(ArrowSchema* schema, ArrowType type)
     ArrowErrorCode ArrowSchemaSetTypeDateTime(ArrowSchema* schema,
@@ -277,6 +278,7 @@ cdef class OracleArrowArray:
             int32_t *as_int32
             double *as_double
             float *as_float
+            int8_t as_bool
             int64_t index
             uint8_t *ptr
             void* temp
@@ -295,6 +297,10 @@ cdef class OracleArrowArray:
             data_buffer = ArrowArrayBuffer(array.arrow_array, 1)
             as_float = <float*> data_buffer.data
             self.append_double(as_float[index])
+        elif array.arrow_type == NANOARROW_TYPE_BOOL:
+            data_buffer = ArrowArrayBuffer(array.arrow_array, 1)
+            as_bool = ArrowBitGet(data_buffer.data, index)
+            self.append_int64(as_bool)
         elif array.arrow_type == NANOARROW_TYPE_DECIMAL128:
             data_buffer = ArrowArrayBuffer(array.arrow_array, 1)
             ArrowDecimalInit(&decimal, 128, self.precision, self.scale)
diff --git a/tests/test_8000_dataframe.py b/tests/test_8000_dataframe.py
@@ -27,6 +27,7 @@
 """
 import datetime
 import decimal
+import unittest
 
 import oracledb
 
@@ -580,6 +581,36 @@ def test_8025(self):
         fetched_data = self.__get_data_from_df(fetched_df)
         self.assertEqual(fetched_data, data)
 
+    @unittest.skipUnless(
+        test_env.get_client_version() >= (23, 1), "unsupported client"
+    )
+    @unittest.skipUnless(
+        test_env.get_server_version() >= (23, 1), "unsupported server"
+    )
+    def test_8026(self):
+        "8026 - fetch boolean"
+        data = [(True,), (False,), (False,), (True,), (True,)]
+        self.__check_interop()
+        ora_df = self.conn.fetch_df_all(
+            """
+            select true
+            union all
+            select false
+            union all
+            select false
+            union all
+            select true
+            union all
+            select true
+            """
+        )
+        fetched_tab = pyarrow.Table.from_arrays(
+            ora_df.column_arrays(), names=ora_df.column_names()
+        )
+        fetched_df = fetched_tab.to_pandas()
+        fetched_data = self.__get_data_from_df(fetched_df)
+        self.assertEqual(fetched_data, data)
+
 
 if __name__ == "__main__":
     test_env.run_test_cases()
diff --git a/tests/test_8100_dataframe_async.py b/tests/test_8100_dataframe_async.py
@@ -536,6 +536,33 @@ async def test_8121(self):
         fetched_data = self.__get_data_from_df(fetched_df)
         self.assertEqual(fetched_data, data)
 
+    @unittest.skipUnless(
+        test_env.get_server_version() >= (23, 1), "unsupported server"
+    )
+    async def test_8122(self):
+        "8122 - fetch boolean"
+        data = [(True,), (False,), (False,), (True,), (True,)]
+        self.__check_interop()
+        ora_df = await self.conn.fetch_df_all(
+            """
+            select true
+            union all
+            select false
+            union all
+            select false
+            union all
+            select true
+            union all
+            select true
+            """
+        )
+        fetched_tab = pyarrow.Table.from_arrays(
+            ora_df.column_arrays(), names=ora_df.column_names()
+        )
+        fetched_df = fetched_tab.to_pandas()
+        fetched_data = self.__get_data_from_df(fetched_df)
+        self.assertEqual(fetched_data, data)
+
 
 if __name__ == "__main__":
     test_env.run_test_cases()
