Fixed bug when using temporary LOBs with implicit pooling.

anthony-tuininga · anthony-tuininga · commit a622afa83cbb · 2025-03-28T20:11:15.000-06:00
diff --git a/doc/src/release_notes.rst b/doc/src/release_notes.rst
@@ -37,6 +37,7 @@ Thin Mode Changes
     (`issue 472 <https://github.com/oracle/python-oracledb/issues/472>`__).
 #)  Fixed bug when connecting to an AC-enabled service
     (`issue 476 <https://github.com/oracle/python-oracledb/issues/476>`__).
+#)  Fixed bug when using temporary LOBs with implicit pooling.
 
 Thick Mode Changes
 ++++++++++++++++++
diff --git a/src/oracledb/impl/thin/lob.pyx b/src/oracledb/impl/thin/lob.pyx
@@ -1,5 +1,5 @@
 #------------------------------------------------------------------------------
-# Copyright (c) 2020, 2024, Oracle and/or its affiliates.
+# Copyright (c) 2020, 2025, Oracle and/or its affiliates.
 #
 # This software is dual-licensed to you under the Universal Permissive License
 # (UPL) 1.0 as shown at https://oss.oracle.com/licenses/upl and Apache License
@@ -56,8 +56,7 @@ cdef class BaseThinLobImpl(BaseLobImpl):
         self._locator = bytes(40)
         message = self._conn_impl._create_message(LobOpMessage)
         message.operation = TNS_LOB_OP_CREATE_TEMP
-        message.amount = TNS_DURATION_SESSION
-        message.send_amount = True
+        message.dest_length = TNS_DURATION_SESSION
         message.source_lob_impl = self
         message.source_offset = self.dbtype._csfrm
         message.dest_offset = self.dbtype._ora_type_num
diff --git a/src/oracledb/impl/thin/messages/lob_op.pyx b/src/oracledb/impl/thin/messages/lob_op.pyx
@@ -35,9 +35,9 @@ cdef class LobOpMessage(Message):
     cdef:
         uint32_t operation
         BaseThinLobImpl source_lob_impl
-        BaseThinLobImpl dest_lob_impl
         uint64_t source_offset
         uint64_t dest_offset
+        uint32_t dest_length
         int64_t amount
         bint send_amount
         bint bool_flag
@@ -75,13 +75,9 @@ cdef class LobOpMessage(Message):
             num_bytes = len(self.source_lob_impl._locator)
             ptr = buf.read_raw_bytes(num_bytes)
             self.source_lob_impl._locator = ptr[:num_bytes]
-        if self.dest_lob_impl is not None:
-            num_bytes = len(self.dest_lob_impl._locator)
-            ptr = buf.read_raw_bytes(num_bytes)
-            self.dest_lob_impl._locator = ptr[:num_bytes]
         if self.operation == TNS_LOB_OP_CREATE_TEMP:
             buf.skip_ub2()                  # skip character set
-            buf.skip_raw_bytes(3)           # skip trailing flags, amount
+            buf.skip_ub1()                  # skip trailing flags
         elif self.send_amount:
             buf.read_sb8(&self.amount)
         if self.operation in (TNS_LOB_OP_IS_OPEN,
@@ -99,12 +95,8 @@ cdef class LobOpMessage(Message):
         else:
             buf.write_uint8(1)              # source pointer
             buf.write_ub4(len(self.source_lob_impl._locator))
-        if self.dest_lob_impl is None:
-            buf.write_uint8(0)              # dest pointer
-            buf.write_ub4(0)                # dest length
-        else:
-            buf.write_uint8(1)              # dest pointer
-            buf.write_ub4(len(self.dest_lob_impl._locator))
+        buf.write_uint8(0)                  # dest pointer
+        buf.write_ub4(self.dest_length)
         buf.write_ub4(0)                    # short source offset
         buf.write_ub4(0)                    # short dest offset
         if self.operation == TNS_LOB_OP_CREATE_TEMP:
@@ -132,8 +124,6 @@ cdef class LobOpMessage(Message):
             buf.write_uint16be(0)
         if self.source_lob_impl is not None:
             buf.write_bytes(self.source_lob_impl._locator)
-        if self.dest_lob_impl is not None:
-            buf.write_bytes(self.dest_lob_impl._locator)
         if self.operation == TNS_LOB_OP_CREATE_TEMP:
             if self.source_lob_impl.dbtype._csfrm == CS_FORM_NCHAR:
                 buf._caps._check_ncharset_id()
