Comment on Files in a Pull Request (Beta) Feedback #49954
Replies: 102 comments 52 replies
-
|
Thank you for adding this feature, I typically leave general comments linked to the bottom line of a file; it'll be much nicer to leave a more general comment. 🙏🏻 |
Beta Was this translation helpful? Give feedback.
-
|
My team in my previous company used to do something similar, but adding a comment to the first line of a file (which is also not ideal). |
Beta Was this translation helpful? Give feedback.
-
|
yea me too, except that I put my comment in the middle of the file |
Beta Was this translation helpful? Give feedback.
-
|
@giovanni-nabil what if the file has an even number of lines? Where do you place your comment? 😆 |
Beta Was this translation helpful? Give feedback.
-
@sjaramillo10 Those files made this practice really cumbersome :) |
Beta Was this translation helpful? Give feedback.
-
|
Love this! This is going to be super useful 🥳 |
Beta Was this translation helpful? Give feedback.
-
|
love this too, hooray ~🥳 |
Beta Was this translation helpful? Give feedback.
-
|
hi |
Beta Was this translation helpful? Give feedback.
-
|
Love this direction! Feedback: It seems that leaving a file-level review comment on a deleted file right now shows that comment as Outdated and isn't displayed in the file view, only being visible in the conversation timeline. |
Beta Was this translation helpful? Give feedback.
-
|
|
Beta Was this translation helpful? Give feedback.
-
|
I have a bit more data - after copying over all my full-file comments to new comments so they would show up inline, I didn't want to deal with the same issue again, so I went ahead and pushed a commit (I can always squash and merge). However, even just pushing a commit caused every full-file comment to be marked outdated, whether it was on a deleted file or not. Also, none of my files were moved. |
Beta Was this translation helpful? Give feedback.
-
|
Ah! I can bet that is what triggered mine as well. |
Beta Was this translation helpful? Give feedback.
-
|
More or less the same here:
The overall feature idea is cool, but I’ll wait for it to be less outdatedness-prone before using it. |
Beta Was this translation helpful? Give feedback.
-
|
Well, this is weird, because all file comments for me get outdated on every push. It creates ao much extra work recreating comments that I went back to commenting on top lines of files instead of using this feature (making it less than useful). So I'm surprised to hear people couldn't reproduce this issue, even with force-pushes and directory moves. I had to restore comments on multiple files after multiple pushes on multiple PRs. I never experienced any file comment retained after a normal push and just gave up using it after a few PRs. This was the discussion I'd created about it: https://github.com/orgs/community/discussions/86527#discussioncomment-9575726 |
Beta Was this translation helpful? Give feedback.
-
|
This is super useful, previously I needed to add generic comments mentioning files, now this will point to the exact file 👍 |
Beta Was this translation helpful? Give feedback.
-
|
I've always wanted this! thank you for adding it! |
Beta Was this translation helpful? Give feedback.
-
|
This is great! In addition to:
it also enables adding a comment on an empty file that was accidentally committed, which coincidentally I had to work around just a few hours ago, but now I can comment directly on it 🤩 Thanks! |
Beta Was this translation helpful? Give feedback.
-
|
Yes, this and binary file comments are not possible otherwise. |
Beta Was this translation helpful? Give feedback.
-
|
Nice - thanks for implementing this! |
Beta Was this translation helpful? Give feedback.
-
|
Awesome! |
Beta Was this translation helpful? Give feedback.
-
|
Great! 🚀 |
Beta Was this translation helpful? Give feedback.
-
|
Hurrah! (A related ask: Can we get keyboard shortcuts to initiate a code comment--on a line or a file--when reviewing? Thanks.) |
Beta Was this translation helpful? Give feedback.
-
|
A nice feature, I was adding comments for the first line of the file before 😭 |
Beta Was this translation helpful? Give feedback.
-
|
Awesome feature..!!! I just used it on a PR. |
Beta Was this translation helpful? Give feedback.
-
|
Really nice! Long awaited feature on my end! |
Beta Was this translation helpful? Give feedback.
-
|
This will be great! There is a z-indexing issue currently. |
Beta Was this translation helpful? Give feedback.
-
|
+1 on Arc Browser
|
Beta Was this translation helpful? Give feedback.
-
|
Thanks! We'll get this fixed. |
Beta Was this translation helpful? Give feedback.
-
|
FYI. The fix for this rolled out earlier today. |
Beta Was this translation helpful? Give feedback.
-
|
Looks great! until now I either left a comment on the 1st line or in a random place stating this it's not related specifically to this line 🙈 |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the great feedback and overwhelming response to this feature! It's now generally available and also now available in GitHub Mobile. |
Beta Was this translation helpful? Give feedback.
-
|
Bug report on files review -- wrong z-order of "Comment on this file" popup hint: Bug: Correct: |
Beta Was this translation helpful? Give feedback.
-
|
Another bug report: wrong text hint on pending comments amount (if you move mouse over the number):
|
Beta Was this translation helpful? Give feedback.
-
|
](url) |
Beta Was this translation helpful? Give feedback.
-
|
Today I ran into an issue. If I try to comment on a file while viewing a single commit in a PR, the comment area tries to open, but nothing is displayed. While, on the other hand, if I review all the changes at once, it works as expected. Short video demo: Screen.Recording.2023-05-05.at.9.56.16.AM_compressed.mp4 |
Beta Was this translation helpful? Give feedback.
-
|
I'm having exactly the same issue as described and screencasted though with commenting on files in already merged PRs. |
Beta Was this translation helpful? Give feedback.
-
|
On a related note: check annotations that are addressed to files (line 0) don't show up at the bottom of "Files changed" https://github.com/TWiStErRob/net.twisterrob.cinema/pull/467/files https://github.com/TWiStErRob/net.twisterrob.cinema/pull/467/checks?check_run_id=13881041239
|
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
When you leave a comment on a file, it's marked as Anyway, thank you for the feature. |
Beta Was this translation helpful? Give feedback.
-
|
Do you mean any push with changes to that specific file or also a push only touching other files? |
Beta Was this translation helpful? Give feedback.
-
|
I wouldn't expect a file level comment to be outdated unless the file is no longer included in the changes for a PR (i.e. a force push drops changes to the file entirely). |
Beta Was this translation helpful? Give feedback.
-
|
Here's an example: nasa/fprime#2316 (comment) |
Beta Was this translation helpful? Give feedback.
-
|
No, he means any push on the branch. I stopped using this feature too because of the same issue. When I push changes on any file, all file comments are outdated, whether those files have changes in them or not. It makes it a useless feature for tracking review issues when you have unresolved review comments. I had started a discussion on the issue here: https://github.com/orgs/community/discussions/86527#discussioncomment-9575726 |
Beta Was this translation helpful? Give feedback.
-
|
The PR view of a comment on a renamed file doesn't include the old filename, which is really problematic as I'm often commenting to show how a filename changed, consider dotnet/fsharp#16212 (comment): Here's the files view which seems to have lost the comment: |
Beta Was this translation helpful? Give feedback.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
-
|
Is it possible to leave file-level comments on a Pull Request when viewing/managing that PR from the context of Github's browser-based code editor (can be opened by pressing |
Beta Was this translation helpful? Give feedback.
-
|
Yes |
Beta Was this translation helpful? Give feedback.
-
|
@jsoref Oh! I don't know how I missed that. Thank you! |
Beta Was this translation helpful? Give feedback.
-
|
It isn't terribly obtrusive. I suspect this is the first time I've seen it -- so now I know it exists because you asked and I went looking -- it also wasn't the first place I looked, although in retrospect, its placement is logical and consistent with how the app works. |
Beta Was this translation helpful? Give feedback.
-
|
💬 Your Product Feedback Has Been Submitted 🎉 Thank you for taking the time to share your insights with us! Your feedback is invaluable as we build a better GitHub experience for all our users. Here's what you can expect moving forward ⏩
Where to look to see what's shipping 👀
What you can do in the meantime 💻
As a member of the GitHub community, your participation is essential. While we can't promise that every suggestion will be implemented, we want to emphasize that your feedback is instrumental in guiding our decisions and priorities. Thank you once again for your contribution to making GitHub even better! We're grateful for your ongoing support and collaboration in shaping the future of our platform. ⭐ |
Beta Was this translation helpful? Give feedback.
-
|
Some changed 1-2 weeks ago - now I can’t add comments in PR’s discussions with active pending review. All my new comments go to pending too. It’s very bad. Old version allow to comment directly or to pending. It was very useful. Please return that buttons.
|
Beta Was this translation helpful? Give feedback.
-
|
That has not changed in the last few weeks. Once you've started a review all diff comments are pending until you submit or cancel the review (you can still post comments in the PR Conversation tab, unattached to the diff). This limitation has been in place for a long time (speaking from experience). |
Beta Was this translation helpful? Give feedback.
-
|
Replies to a review comment aren't loaded in without refreshing the page, regular comments under PRs however are. This kind of behavior is unexpected, either replies to review comments should load in realtime or regular comments shouldn't be loaded in live as well. |
Beta Was this translation helpful? Give feedback.
-
|
Can we get more details about how to do this via API? When I look at the docs here for creating a review position/line aren't said to be required but when I omit them I get a 422 and a message saying 0.position is expected to be not null. Do I need to include another field to let the API know I want a file comment? When I make a file level comment through the UI and request the comment via api I see it has a line number of 1. I also notice from the docs the last supported api version is from 2022? Is there a beta flag I can pass to get new features? |
Beta Was this translation helpful? Give feedback.
-
Commenting on a file in a pull request (not just a specific line) is
available in public betanow generally available.This feature lets you comment on deleted, binary (including images), and renamed files in a pull request. You can also comment generally about a changed code file without having to attach the comment to a specific line.
Learn more about commenting on a pull request (docss) or see the beta changelog for more details.
Known issues
GitHub Mobile support is coming🎉 SHIPPED 🎉API support is coming🎉 SHIPPED 🎉Tell us what you think
Let us know if you run into problems, have questions, have a request, or just wanna say how useful (or not) this feature is!
Beta Was this translation helpful? Give feedback.
All reactions