Skip to content

Commit d00a15e

Browse files
authored
add 3.10 exemption for composer blog noxfile_configs (GoogleCloudPlatform#6981)
## Description This will address the composer part of GoogleCloudPlatform#6974 Note: It's a good idea to open an issue first for discussion. ## Checklist - [x] I have followed [Sample Guidelines from AUTHORING_GUIDE.MD](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md) - [x] README is updated to include [all relevant information](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#readme-file) - [x] **Tests** pass: `nox -s py-3.6` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#test-environment-setup)) - [x] **Lint** pass: `nox -s lint` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/AUTHORING_GUIDE.md#test-environment-setup)) - [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones) - [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones) - [x] Please **merge** this PR for me once it is approved. - [ ] This sample adds a new sample directory, and I updated the [CODEOWNERS file](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/master/.github/CODEOWNERS) with the codeowners for this sample
1 parent 97641d8 commit d00a15e

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

composer/blog/gcp-tech-blog/data-orchestration-with-composer/noxfile_config.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@
3636
"3.6",
3737
"3.7",
3838
"3.9",
39+
"3.10"
3940
], # Composer w/ Airflow 2 only supports Python 3.8
4041
# Old samples are opted out of enforcing Python type hints
4142
# All new samples should feature them

composer/blog/gcp-tech-blog/unit-test-dags-cloud-build/noxfile_config.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
TEST_CONFIG_OVERRIDE = {
3333
# You can opt out from the test for specific Python versions.
3434
# Skipping for Python 3.9 due to numpy compilation failure.
35-
"ignored_versions": ["2.7", "3.9"],
35+
"ignored_versions": ["2.7", "3.9", "3.10"],
3636
# Old samples are opted out of enforcing Python type hints
3737
# All new samples should feature them
3838
"enforce_type_hints": False,

0 commit comments

Comments
 (0)