Skip to content

Commit e8f617c

Browse files
committed
Minor improvements.
1 parent 77d673a commit e8f617c

File tree

2 files changed

+20
-59
lines changed

2 files changed

+20
-59
lines changed

README.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@ display_name: Laravel (PHP 8.3)
33
description: Coder Template for Laravel (PHP 8.3)
44
icon: https://laravel.com/img/logomark.min.svg
55
maintainer_github: vkambulov
6-
verified: true
7-
tags: [docker, container, laravel, php]
6+
tags: [docker, laravel, php]
87
---
98

109
# Remote Development for Laravel
@@ -21,7 +20,6 @@ Work in progress. There may be some errors.
2120
- MySQL 8.0
2221
- Cloning GitHub private repos with [Coder External Auth](https://coder.com/docs/v2/latest/admin/external-auth)
2322
- [JetBrains Gateway](https://registry.coder.com/modules/jetbrains-gateway), [VS Code Desktop](https://registry.coder.com/modules/vscode-desktop) and [VS Code in the browser](https://code-server.dev)
24-
- Sharing home directory between several projects
2523
- [File Browser](https://registry.coder.com/modules/filebrowser)
2624

2725
## TODO

main.tf

Lines changed: 19 additions & 56 deletions
Original file line numberDiff line numberDiff line change
@@ -84,8 +84,7 @@ resource "coder_agent" "main" {
8484
arch = data.coder_provisioner.me.arch
8585
os = "linux"
8686
startup_script = "/usr/local/bin/start.sh"
87-
88-
dir = "/var/www/html"
87+
dir = "/var/www/html"
8988

9089
env = {
9190
GIT_AUTHOR_NAME = data.coder_workspace.me.owner
@@ -156,33 +155,6 @@ resource "coder_agent" "main" {
156155
}
157156
}
158157

159-
resource "docker_volume" "workspaces" {
160-
name = "coder-${data.coder_workspace.me.id}"
161-
# Protect the volume from being deleted due to changes in attributes.
162-
lifecycle {
163-
ignore_changes = all
164-
}
165-
# Add labels in Docker to keep track of orphan resources.
166-
labels {
167-
label = "coder.owner"
168-
value = data.coder_workspace.me.owner
169-
}
170-
labels {
171-
label = "coder.owner_id"
172-
value = data.coder_workspace.me.owner_id
173-
}
174-
labels {
175-
label = "coder.workspace_id"
176-
value = data.coder_workspace.me.id
177-
}
178-
# This field becomes outdated if the workspace is renamed but can
179-
# be useful for debugging or cleaning out dangling volumes.
180-
labels {
181-
label = "coder.workspace_name_at_creation"
182-
value = data.coder_workspace.me.name
183-
}
184-
}
185-
186158
data "coder_parameter" "repo" {
187159
name = "repo"
188160
display_name = "Repository (auto)"
@@ -212,37 +184,18 @@ data "coder_parameter" "custom_repo_url" {
212184
mutable = true
213185
}
214186

215-
data "coder_parameter" "home_volume" {
216-
name = "home_volume"
217-
display_name = "Home folder volume"
218-
order = 3
219-
description = "Select how the Home folder volume will be used."
220-
mutable = true
221-
222-
option {
223-
name = "Local"
224-
description = "The volume name will only be associated with this project"
225-
value = "${docker_volume.workspaces.name}-home"
226-
}
227-
option {
228-
name = "Global"
229-
description = "The volume can be reused for other projects"
230-
value = "coder-home"
231-
}
232-
}
233-
234187
data "coder_parameter" "laravel_seed" {
235188
name = "laravel_seed"
236189
display_name = "Run Laravel Seeder?"
237-
order = 4
190+
order = 3
238191
description = "Run db:seed command after setting up project."
239192
type = "bool"
240193
mutable = true
241194
default = false
242195
}
243196

244197
resource "docker_image" "main" {
245-
name = "coder-${data.coder_workspace.me.id}"
198+
name = data.coder_workspace.me.name
246199

247200
build {
248201
context = "./build"
@@ -258,14 +211,15 @@ resource "docker_image" "main" {
258211
}
259212

260213
resource "docker_network" "private_network" {
261-
name = "network-${data.coder_workspace.me.id}"
214+
name = "coder-${data.coder_workspace.me.name}-network"
262215
}
263216

264217
resource "docker_container" "dind" {
265218
image = "docker:dind"
266219
privileged = true
267-
name = "dind-${data.coder_workspace.me.id}"
220+
name = "coder-${data.coder_workspace.me.name}-dind"
268221
entrypoint = ["dockerd", "-H", "tcp://0.0.0.0:2375"]
222+
269223
networks_advanced {
270224
name = docker_network.private_network.name
271225
}
@@ -308,25 +262,25 @@ resource "docker_container" "workspace" {
308262

309263
volumes {
310264
container_path = "/var/www/html"
311-
volume_name = docker_volume.workspaces.name
265+
volume_name = "coder-${data.coder_workspace.me.name}-project"
312266
read_only = false
313267
}
314268

315269
volumes {
316270
container_path = "/var/lib/mysql"
317-
volume_name = "${docker_volume.workspaces.name}-mysql"
271+
volume_name = "coder-${data.coder_workspace.me.name}-mysql"
318272
read_only = false
319273
}
320274

321275
volumes {
322276
container_path = "/var/lib/postgresql/data"
323-
volume_name = "${docker_volume.workspaces.name}-postgresql"
277+
volume_name = "coder-${data.coder_workspace.me.name}-postgresql"
324278
read_only = false
325279
}
326280

327281
volumes {
328282
container_path = "/home/coder"
329-
volume_name = data.coder_parameter.home_volume.value
283+
volume_name = "coder-${data.coder_workspace.me.name}-home"
330284
read_only = false
331285
}
332286

@@ -346,4 +300,13 @@ resource "docker_container" "workspace" {
346300
label = "coder.workspace_name"
347301
value = data.coder_workspace.me.name
348302
}
303+
304+
labels {
305+
label = "coder.workspace_name_at_creation"
306+
value = data.coder_workspace.me.name
307+
}
308+
309+
lifecycle {
310+
ignore_changes = all
311+
}
349312
}

0 commit comments

Comments
 (0)