-
Notifications
You must be signed in to change notification settings - Fork 3.1k
[FIX] Side menu collapses info in landscape #4580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
LGTM 👍 |
QA checks:
|
After checking the accessibility regards on this issue and going back to our history to find the original cause, i stumbled upon the following QA report: The problem caused in the accessibility wasn't the blank spaces themselves, but the numbering in the dictation. The fix introduced in the current PR does not fix this, since all the items in the drawer list are pronounced as "x of 7" when there are only 4 (i miss one¿?) I tested by removing the Therefore, we need a compromise solution:
|
Since there is no a totally fittable solution, we'll go for the first approach:
there are other risky solutions that can lead to other bigger problems and bad UI/UX situations that are not worthy at this point. Finally:
As usual, new feedback to receive is always welcome and we are open to new improvements and iterations in the feature. Agreed @joragua? |
Yeah, I agree. There could be another compromise solution but I think that, at the moment we are, is not feasible: modify the drawer layout and have an empty block between the menu and the footer (for example). I've tried it but the drawer collapses many times so, in my opinion, it is not worthy to work on it. 🤔 In this case, I would prefer to keep the bad numbering dictation from Talkback and fix the drawer glitch. |
Approved, then. |
Related Issues
App: #4513
ReleaseNotesViewModel.kt
creating a newReleaseNote()
with String resources (if required)QA