Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH1089Fix nightly for pandas 3.0.0 due to future warnings #1122

Merged
merged 2 commits into from
Feb 18, 2025

Conversation

loicdiridollou
Copy link
Contributor

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Feb 18, 2025

/pandas_nightly

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Feb 18, 2025

The test to do the nightly test from here didn't work. See https://github.com/pandas-dev/pandas-stubs/actions/runs/13394741704/job/37410799701#step:3:64

Can you look into that? If it's too hard, let me know, and I'll approve this PR.

@loicdiridollou
Copy link
Contributor Author

/pandas_nightly

@loicdiridollou
Copy link
Contributor Author

@Dr-Irv I understand the error, the initial issue with the comment commands was that it would checkout the main branch and not the one we want to merge so I fixed this. Now the issue is that it is looking for the branch in the pandas-stubs repo although in the current setting the branch in on my personal repo (loicdiridollou/pandas-stubs).
I will fix this in a separate PR, just need to test it on a dummy repo on my end so would be preferable to merge this one (I tested the changes locally running poetry run poe pytest --nightly and it was good.

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr-Irv Dr-Irv merged commit 108e41c into pandas-dev:main Feb 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix pandas nightly test build and migrate tests over new framework
2 participants