Convert Reference.IsLocalBranch() into a property

nulltoken · nulltoken · commit 450fb1b043a2 · 2015-06-18T17:45:07.000+02:00
diff --git a/LibGit2Sharp.Tests/ReferenceFixture.cs b/LibGit2Sharp.Tests/ReferenceFixture.cs
@@ -829,7 +829,7 @@ public void CanIdentifyReferenceKind()
             string path = SandboxStandardTestRepo();
             using (var repo = new Repository(path))
             {
-                Assert.True(repo.Refs["refs/heads/master"].IsLocalBranch());
+                Assert.True(repo.Refs["refs/heads/master"].IsLocalBranch);
                 Assert.True(repo.Refs["refs/remotes/origin/master"].IsRemoteTrackingBranch());
                 Assert.True(repo.Refs["refs/tags/lw"].IsTag());
             }
diff --git a/LibGit2Sharp/Reference.cs b/LibGit2Sharp/Reference.cs
@@ -87,9 +87,9 @@ public static bool IsValidName(string canonicalName)
         /// Determine if the current <see cref="Reference"/> is a local branch.
         /// </summary>
         /// <returns>true if the current <see cref="Reference"/> is a local branch, false otherwise.</returns>
-        public virtual bool IsLocalBranch()
+        public virtual bool IsLocalBranch
         {
-            return CanonicalName.LooksLikeLocalBranch();
+            get { return CanonicalName.LooksLikeLocalBranch(); }
         }
 
         /// <summary>
diff --git a/LibGit2Sharp/ReferenceCollection.cs b/LibGit2Sharp/ReferenceCollection.cs
@@ -214,7 +214,7 @@ public virtual Reference Rename(Reference reference, string newName, string logM
             if (logMessage == null)
             {
                 logMessage = string.Format(CultureInfo.InvariantCulture, "{0}: renamed {1} to {2}",
-                    reference.IsLocalBranch() ? "branch" : "reference", reference.CanonicalName, newName);
+                    reference.IsLocalBranch ? "branch" : "reference", reference.CanonicalName, newName);
             }
 
             using (ReferenceSafeHandle referencePtr = RetrieveReferencePtr(reference.CanonicalName))
diff --git a/LibGit2Sharp/Repository.cs b/LibGit2Sharp/Repository.cs
@@ -851,7 +851,7 @@ public Branch Checkout(string committishOrBranchSpec, CheckoutOptions options)
                 if (!refH.IsInvalid)
                 {
                     var reference = Reference.BuildFromPtr<Reference>(refH, this);
-                    if (reference.IsLocalBranch())
+                    if (reference.IsLocalBranch)
                     {
                         Branch branch = Branches[reference.CanonicalName];
                         return Checkout(branch, options);

Original file line number	Diff line number	Diff line change
`@@ -829,7 +829,7 @@ public void CanIdentifyReferenceKind()`
`829`	`829`	`string path = SandboxStandardTestRepo();`
`830`	`830`	`using (var repo = new Repository(path))`
`831`	`831`	`{`
`832`		`- Assert.True(repo.Refs["refs/heads/master"].IsLocalBranch());`
	`832`	`+ Assert.True(repo.Refs["refs/heads/master"].IsLocalBranch);`
`833`	`833`	`Assert.True(repo.Refs["refs/remotes/origin/master"].IsRemoteTrackingBranch());`
`834`	`834`	`Assert.True(repo.Refs["refs/tags/lw"].IsTag());`
`835`	`835`	`}`
Original file line number	Diff line number	Diff line change
`@@ -87,9 +87,9 @@ public static bool IsValidName(string canonicalName)`
`87`	`87`	`/// Determine if the current <see cref="Reference"/> is a local branch.`
`88`	`88`	`/// </summary>`
`89`	`89`	`/// <returns>true if the current <see cref="Reference"/> is a local branch, false otherwise.</returns>`
`90`		`- public virtual bool IsLocalBranch()`
	`90`	`+ public virtual bool IsLocalBranch`
`91`	`91`	`{`
`92`		`- return CanonicalName.LooksLikeLocalBranch();`
	`92`	`+ get { return CanonicalName.LooksLikeLocalBranch(); }`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`/// <summary>`
Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,7 @@ public virtual Reference Rename(Reference reference, string newName, string logM`
`214`	`214`	`if (logMessage == null)`
`215`	`215`	`{`
`216`	`216`	`logMessage = string.Format(CultureInfo.InvariantCulture, "{0}: renamed {1} to {2}",`
`217`		`- reference.IsLocalBranch() ? "branch" : "reference", reference.CanonicalName, newName);`
	`217`	`+ reference.IsLocalBranch ? "branch" : "reference", reference.CanonicalName, newName);`
`218`	`218`	`}`
`219`	`219`
`220`	`220`	`using (ReferenceSafeHandle referencePtr = RetrieveReferencePtr(reference.CanonicalName))`
Original file line number	Diff line number	Diff line change
`@@ -851,7 +851,7 @@ public Branch Checkout(string committishOrBranchSpec, CheckoutOptions options)`
`851`	`851`	`if (!refH.IsInvalid)`
`852`	`852`	`{`
`853`	`853`	`var reference = Reference.BuildFromPtr<Reference>(refH, this);`
`854`		`- if (reference.IsLocalBranch())`
	`854`	`+ if (reference.IsLocalBranch)`
`855`	`855`	`{`
`856`	`856`	`Branch branch = Branches[reference.CanonicalName];`
`857`	`857`	`return Checkout(branch, options);`