Non-array query values cause query to end with an error.

brianc · brianc · commit ca68425e1c44 · 2017-07-15T11:14:15.000-05:00
This is a small change and is _kinda_ backwards compatible since the old behavior was to throw an error, but if someone was relying on anything with `.map` working as values it would break them, so it's in a major semver bump.
diff --git a/lib/native/query.js b/lib/native/query.js
@@ -146,8 +146,11 @@ NativeQuery.prototype.submit = function(client) {
       client.namedQueries[self.name] = true;
       return self.native.execute(self.name, values, after);
     });
-  }
-  else if(this.values) {
+  } else if(this.values) {
+    if (!Array.isArray(this.values)) {
+      const err = new Error('Query values must be an array')
+      return after(err)
+    }
     var vals = this.values.map(utils.prepareValue);
     client.native.query(this.text, vals, after);
   } else {
diff --git a/lib/query.js b/lib/query.js
@@ -133,6 +133,12 @@ Query.prototype.submit = function(connection) {
     connection.emit('readyForQuery')
     return
   }
+  if (this.values && !Array.isArray(this.values)) {
+    const err = new Error('Query values must be an array')
+    connection.emit('error', err)
+    connection.emit('readyForQuery')
+    return
+  }
   if(this.requiresPreparation()) {
     this.prepare(connection);
   } else {
diff --git a/test/integration/client/error-handling-tests.js b/test/integration/client/error-handling-tests.js
@@ -17,6 +17,19 @@ var createErorrClient = function() {
 
 const suite = new helper.Suite('error handling')
 
+suite.test('sending non-array argument as values causes an error callback', (done) => {
+  const client = new Client()
+  client.connect(() => {
+    client.query('select $1::text as name', 'foo', (err) => {
+      assert(err instanceof Error)
+      client.query('SELECT $1::text as name', ['foo'], (err, res) => {
+        assert.equal(res.rows[0].name, 'foo')
+        client.end(done)
+      })
+    })
+  })
+})
+
 suite.test('re-using connections results in error callback', (done) => {
   const client = new Client()
   client.connect(() => {
diff --git a/test/native/error-tests.js b/test/native/error-tests.js
