Skip to content

Feature flags should retain flag state after refresh #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
phenixcoder opened this issue Aug 28, 2020 · 2 comments
Open

Feature flags should retain flag state after refresh #2

phenixcoder opened this issue Aug 28, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@phenixcoder
Copy link
Owner

When feature flags are initialised, the initialise function should check for existing feature flags and their states and apply saved state on top of passed feature flags.

In case of refresh, the updated feature flags get reset.
@phenixcoder phenixcoder added the enhancement New feature or request label Aug 28, 2020
@atombrenner
Copy link

In my app, feature flags are stored in localStorage. I use your extension to toggle features. If the chrome extension stores the state by itself and overrides the state supplied by the app, my app integration would no longer work.
I suggest, that the app can control this behavior.

@phenixcoder
Copy link
Owner Author

When configuring feature flags, We can control this by passing additional attribute to use plugin storage or not use storage at all.

In my case I use this for development and with every refresh, I need to toggle my feature flags again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@atombrenner @phenixcoder