Skip to content

Commit c068082

Browse files
committed
pr comments
1 parent 85e73c2 commit c068082

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

CONTRIBUTING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ To create a new module, clone this repository and run:
1010

1111
A suite of test-helpers exists to run `terraform apply` on modules with variables, and test script output against containers.
1212

13-
The testing suite must be able to run docker containers with the `--network=host` flag, which typically requires running the tests on linux as this flag does not apply to Docker Desktop for MacOS and Windows. MacOS users can work around this by using something like [Orbstack](https://orbstack.dev/) instead of Docker Desktop.
13+
The testing suite must be able to run docker containers with the `--network=host` flag, which typically requires running the tests on Linux as this flag does not apply to Docker Desktop for MacOS and Windows. MacOS users can work around this by using something like [colima](https://github.com/abiosoft/colima) or [Orbstack](https://orbstack.dev/) instead of Docker Desktop.
1414

1515
Reference existing `*.test.ts` files for implementation.
1616

github-upload-public-key/run.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,22 @@
33
set -e
44

55
if [ -z "$CODER_ACCESS_URL" ]; then
6-
echo "No CODER_ACCESS_URL specified!"
6+
echo "CODER_ACCESS_URL is empty!"
77
exit 1
88
fi
99

1010
if [ -z "$CODER_OWNER_SESSION_TOKEN" ]; then
11-
echo "No CODER_OWNER_SESSION_TOKEN specified!"
11+
echo "CODER_OWNER_SESSION_TOKEN is empty!"
1212
exit 1
1313
fi
1414

1515
if [ -z "$CODER_EXTERNAL_AUTH_ID" ]; then
16-
echo "No CODER_EXTERNAL_AUTH_ID specified!"
16+
echo "CODER_EXTERNAL_AUTH_ID is empty!"
1717
exit 1
1818
fi
1919

2020
if [ -z "$GITHUB_API_URL" ]; then
21-
echo "No GITHUB_API_URL specified!"
21+
echo "GITHUB_API_URL is empty!"
2222
exit 1
2323
fi
2424

0 commit comments

Comments
 (0)